Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] CI: Include rzup in workflow #1777

Open
hmrtn opened this issue May 3, 2024 · 2 comments
Open

[Feature] CI: Include rzup in workflow #1777

hmrtn opened this issue May 3, 2024 · 2 comments
Assignees
Labels

Comments

@hmrtn
Copy link
Member

hmrtn commented May 3, 2024

Feature

We should introduce CI tests for the recently added rzup installation scripts (#1774).

Motivation

To test the installation process works as intended via rzup when changes occur to the scripts, or general install procedure.

Implementation

There is a reference comment for adding a new job to the main workflow here: #1774 (comment)

@morgangibbs87 alternatively pointed out these CI tests can be included in the nightly workflow, or in the scripts workflow with something like this block:

- name: Install rzup
  env:
    GITHUB_SHA: ${{ github.sha }}
  run: bash ./install
  working-directory: ./rzup

- name: Installs RISC Zero and Toolchain
  env:
    GITHUB_SHA: ${{ github.sha }}
  run: bash ./rzup
  working-directory: ./rzup
@hmrtn hmrtn added the enhancement New feature or request label May 3, 2024
Copy link

linear bot commented May 3, 2024

@hmrtn hmrtn added ci and removed enhancement New feature or request labels May 3, 2024
@morgangibbs87
Copy link
Contributor

Forgot to add shell to the sample CI I gave. Without it you might get an error.

Corrected:

- name: Install rzup
  env:
    GITHUB_SHA: ${{ github.sha }}
  run: bash ./install
  shell: bash
  working-directory: ./rzup

- name: Installs RISC Zero and Toolchain
  env:
    GITHUB_SHA: ${{ github.sha }}
  run: bash ./rzup
  shell: bash
  working-directory: ./rzup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants