Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Support compression to CompactReceipt through the protobuf client/server API #1760

Closed
nategraf opened this issue Apr 30, 2024 · 3 comments · Fixed by #1870
Closed

[Feature] Support compression to CompactReceipt through the protobuf client/server API #1760

nategraf opened this issue Apr 30, 2024 · 3 comments · Fixed by #1870
Labels
enhancement New feature or request

Comments

@nategraf
Copy link
Contributor

nategraf commented Apr 30, 2024 •
edited

Feature

Support compression to CompactReceipt through the protobuf client/server API

Motivation

Currently, compression to CompactReceipt is only possible when using LocalProver built using the -F prove flag.
As a result, users that install r0vm with cargo-binstall will not be able to produce compact (Groth16) receipts via the comperes method, even on x86 machines with Docker installed.

Note that users can still produce compact receipts by passing receipt_kind = ReceiptKind::Compact with their initial request to prove.

Related: #1749
@nategraf nategraf added the enhancement New feature or request label Apr 30, 2024
@linear Linear
Copy link

linear bot commented Apr 30, 2024

ZKVM-421 [Feature] Support compression to CompactReceipt through the protobuf client/server API

@flaub
Copy link
Member

flaub commented May 8, 2024

@nategraf is this done with #1762?

@nategraf
Copy link
Contributor Author

nategraf commented May 8, 2024

No. That doesn't have any methods to send a request to run the Groth16 step over protobuf.

@SchmErik SchmErik mentioned this issue May 21, 2024
Merged
SchmErik added a commit that referenced this issue May 22, 2024
@SchmErik
Client/Server: add plumbing for compress (#1870)
57b45bd 
This change completes the implementation of the `ExternalProver`'s
`compress` function by implementing plumbing for the `compress` function
in the client server architecture. The composite to succinct function
has been removed from `ExternalProver` because a call to compress has
the same effect without having to pass segment receipts between the
client and server.

Closes: #1760
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Client/Server: add plumbing for compress risc0/risc0
2 participants
@flaub @nategraf