Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: patch-package required for MV2/MV3 clean install #1640

Open
1 of 4 tasks
mikedidomizio opened this issue Apr 27, 2024 · 0 comments
Open
1 of 4 tasks

bug: patch-package required for MV2/MV3 clean install #1640

mikedidomizio opened this issue Apr 27, 2024 · 0 comments
Assignees
Labels
issue Distinguish between PR and Issue type: bug

Comments

@mikedidomizio
Copy link

Describe your issue?

patch-package is a dev dependency of the requestly-web-sdk. patch-package is run as part of the postinstall of that package.

If you try to install/build the MV2 in this package without previously installing patch-package like previously done here (removed here), you end up with build failures:

npm WARN deprecated har-validator@5.1.5: this library is no longer supported
npm WARN deprecated sign-addon@5.3.0: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
npm WARN deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated core-js@2.6.12: core-js@<3.23.3 is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Some versions have web compatibility issues. Please, upgrade your dependencies to the actual version of core-js.
npm ERR! code 127
npm ERR! path /Users/Mike.DiDomizio/projects/test/requestly/browser-extension/mv2/node_modules/@requestly/web-sdk
npm ERR! command failed
npm ERR! command sh -c patch-package
npm ERR! sh: patch-package: command not found

npm ERR! A complete log of this run can be found in: /Users/Mike.DiDomizio/.npm/_logs/2024-04-27T00_36_53_182Z-debug-0.log

patch-package is also part of MV3 extension and the app package.

  • It also fails with MV3
  • It doesn't fail as part of the app package because it's patch-package is installed as part of the devDependencies

Repro steps

  1. Ensure that you don't have patch-package installed as a global package
  2. Clone this package
  3. Run the ./install.sh

Expected Result:

  • Install packages successfully

Actual Result:

  • Fails when installing request-web-sdk with error command not found for patch-package

What Requestly tool were you using?

  • Extension
  • Desktop-App
  • Android SDK
  • Selenium

Your Environment

MacOS 14, Node 18.18.2, NPM 9.8.1

Requestly Version

1.0.3

Error screenshot

No response

@mikedidomizio mikedidomizio added issue Distinguish between PR and Issue type: bug labels Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue Distinguish between PR and Issue type: bug
Projects
None yet
Development

No branches or pull requests

2 participants