Node docker images upgrade broken since 2023-12-01 #29113
Replies: 2 comments
-
Hi there, Get your discussion fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible. Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this. Discussions without reproductions are less likely to be converted to Issues. To get started, please read our guide on creating a minimal reproduction. Good luck, The Renovate team |
Beta Was this translation helpful? Give feedback.
-
I think your title is exaggerating/alarmist and can cause unnecessary confusion for users searching or browsing discussions. Please correct it to more accurate reflect the narrower use case which you've found to be not working. e.g. it may be related purely to upgrades from v21 to v22, which is itself related to them being non-LTS. |
Beta Was this translation helpful? Give feedback.
-
What would you like help with?
I think I found a bug
How are you running Renovate?
Self-hosted
If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.
gitlab
Please tell us more about your question or problem
I discovered recently that the upgrade of all our nodejs docker images stopped working because Node 22 was released, and our images kept using v21.7.3.
Most our node versions are defined in .gitlab-ci.yml using :
Which is handled by a custom manager (quasi verbatim from renovate's sources):
And it used to work just fine.
As upgrading was not really an issue (we don't have nodejs apps directly facing the internet) I changed a thing here and there, but nothing worked, so today, I started looking in the logs, and I saw the versioning in this (see logs below)
So, first, I tried adding a package rule forcing docker versioning when matchDatasource=docker and matchDepName=node, but it did not work, so I started looking in renovate's sources, and I found e9ee32e which adds a workaround for node docker images to the workaround:all preset that is included in config:recommended that I use. So, I added
ignorePresets: ["workarounds:nodeDockerVersioning"],
to my config, and now, everything works as it was working before.The node.js version documentation explicitely states:
So, having a preset that is recommended explicitely going against what the doc says seems a bit wrong.
Logs (if relevant)
Logs
Beta Was this translation helpful? Give feedback.
All reactions