Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Remove LispCons from the name of LispConsEndChecks #1514

Open
agraven opened this issue Jun 9, 2019 · 1 comment
Open

Suggestion: Remove LispCons from the name of LispConsEndChecks #1514

agraven opened this issue Jun 9, 2019 · 1 comment

Comments

@agraven
Copy link
Collaborator

agraven commented Jun 9, 2019

...and LispConsCircularChecks

The official rust style guidelines state that redundant prefixes should be avoided. I consider the LispCons part of these type names redundant. As the style guide says, module names should be used to disambiguate - I consider the lists module name perfectly fit for this purpose - or renaming imports in cases where that's necessary.

The current type names are long and take up frustratingly large amounts of line real-estate, for no benefit.

@shaleh
Copy link
Collaborator

shaleh commented Jun 10, 2019

I would have liked to have done this more like C++ or other type systems and defined EndChecks and CircularChecks inside of LispCons and had LispCons::EndChecks.

The lists module is itself not sufficient in my opinion as a name space for these. We could move some of it to a cons.rs which would better map.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants