[BUG] <Show isLoading={true}> with Material UI doesn't show loading spinner

[rners01]

Describe the bug

<Show isLoading={true}> with Material UI doesn't show loading spinner

Steps To Reproduce

1. Create view with isLoading prop set to true
2. Observe no spinner shown

Expected behavior

Spinner on isLoading=true

Packages

"@refinedev/cli": "2.16.24",
"@refinedev/core": "4.47.1",
"@refinedev/kbar": "1.3.6",
"@refinedev/mui": "5.14.4",
"@refinedev/react-hook-form": "4.8.14",
"@refinedev/react-router-v6": "4.5.5",
"@refinedev/simple-rest": "5.0.2",

Additional Context

No response

[issa012]

Hello, I tried to recreate this bug. It is working as you said, there is no loading spinner. However, I think that is the expected behavior. When loading, the component doesn't show a loading spinner, but disables the refresh button. I found that here in the documentation:
https://refine.dev/docs/ui-integrations/material-ui/components/basic-views/show/#isloading

[BatuhanW]

Thanks for the explanation, @issa012. As mentioned you can use this prop to disable refresh button.

[rners01]

@BatuhanW @issa012
It's not looking pretty with default values displaying first and then jumping to the API data.
Also Mantine and Ant UI integrations have loading spinner for such scenarios, that's why I though it could be the bug.
So there's no plan to add spinner?

[BatuhanW]

@rners01 While it's not a bug, we are open to contributions if someone would like to work on this one.

[issa012]

I can try, if you assign this to me.

[BatuhanW]

Sure, assigned to you. 🚀

[rners01]

@BatuhanW wrong assigned, should've been @issa012 (:

[rners01]

@BatuhanW Was the feature merged?

[0xJaskeerat]

Hey @rners01 @BatuhanW
I would love to try on this issue , can you please assign me ?