Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Table representation is broken in Data Fetching guide #5502

Closed
alicanerdurmaz opened this issue Jan 11, 2024 · 17 comments
Closed

[BUG] Table representation is broken in Data Fetching guide #5502

alicanerdurmaz opened this issue Jan 11, 2024 · 17 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers wontfix This will not be worked on

Comments

@alicanerdurmaz
Copy link
Member

alicanerdurmaz commented Jan 11, 2024

Describe the bug

The table representation within the relationship section of the data-fetching documentation looks broken.

Steps To Reproduce

  1. Go to https://refine.dev/docs/guides-concepts/data-fetching/#relationships
  2. Look at the table representation.

Expected behavior

Borders should be aligned.

Screenshot

image

@alicanerdurmaz alicanerdurmaz added bug Something isn't working good first issue Good for newcomers documentation Improvements or additions to documentation labels Jan 11, 2024
@amirk85
Copy link

amirk85 commented Jan 11, 2024

I believe it's already aligned, working fine for me @alicanerdurmaz

Screenshot from 2024-01-12 03-37-15

@AnasGrzor
Copy link

I believe it's already aligned, working fine for me @alicanerdurmaz

Screenshot from 2024-01-12 03-37-15

If you check out the docs you can see the borders are misaligned. In my vscode it also appeared fine but for some reason in the docs it's weird.

@amirk85
Copy link

amirk85 commented Jan 11, 2024

@AnasGrzor not able to see the screenshot you attached.
And also I don't see any misalignment in the doc as well

attaching a short clip

Screencast.from.12-01-24.04.09.05.AM.IST.webm

@AnasGrzor
Copy link

@amirk85
Screenshot_2024-01-12-03-45-48-050_com android chrome
This is in chrome

@alicanerdurmaz
Copy link
Member Author

Hello @AnasGrzor and @amirk85, thanks for helping Refine.

It's an interesting problem 🤔. I will investigate too.

@aliemir
Copy link
Member

aliemir commented Jan 12, 2024

Hey everyone, thank you for your interests and effort in this issue! I've suspected that this is happening due to fallbacks provided in the font family definition. I've checked in my local to update the tailwind.config.js like this for the JetBrains Mono:

"jetBrains-mono": [
                    "JetBrains Mono",
-                   ...defaultTheme.fontFamily.mono,
+                   "monospace"
                ],

The issue resolved for me.

Can anyone check if the same solution works for them as well? If its resolved, we'll be happy to see a PR addressing this change 🙏

@AnasGrzor
Copy link

image
I did the change but it's still the same
image

@Conqxeror
Copy link
Contributor

It is caused by font-family: Source Code Pro @aliemir @BatuhanW @alicanerdurmaz

With Font :

SS for issue.

Screenshot 2024-01-17 112148

Reason for issue.

Screenshot 2024-01-17 112203

Without Font

Issue Fix If:

Screenshot 2024-01-17 112751

After removal of: font-family: Source Code Pro :

Screenshot 2024-01-17 112819

@notnick2
Copy link

Is the issue resolved? If not, I'm excited to work on resolving it.

@alicanerdurmaz
Copy link
Member Author

@notnick2 Thanks 🚀, I assigned the issue to you.

@CodeKage25
Copy link

CodeKage25 commented Feb 6, 2024

Hi @alicanerdurmaz , has this issue been fixed already? If not, can I fix it?

@alicanerdurmaz
Copy link
Member Author

@CodeKage25 Thanks, I assigned it to you.

@alicanerdurmaz alicanerdurmaz assigned CodeKage25 and unassigned notnick2 Feb 6, 2024
@BatuhanW BatuhanW added this to the March Release milestone Feb 6, 2024
@BatuhanW BatuhanW removed this from the March Release milestone Feb 29, 2024
@domlimm
Copy link

domlimm commented Mar 9, 2024

@alicanerdurmaz Hey Alican, may I have a go at this? A little occupied in the next 4 days. Will work on it roughly mid of next week or ASAP. If you're okay with it!

@BatuhanW
Copy link
Member

Hey @domlimm let us know when you can work on this, let's assign to you.

@domlimm
Copy link

domlimm commented Mar 22, 2024

@BatuhanW Hey Bathuan! I did some digging last week and just for an hour before writing this.. Seems okay on VSCode (but I suppose that's not the case/what we're trying to fix). However, I checked on prod and it seems slightly off. I'm on macOS, checked on Chrome.

VSCode:
image

Chrome:
image

Safari:
image

On Windows Chrome (both locally and prod):
Exactly what's shown in the opening of this issue.

I am actually struggling to find out the root cause. It's odd because it's a table in markdown.

@JamieBort
Copy link

There's a lot of hands working on this issue. If there is anything that I can do to help, please let me know.
Otherwise I'll continue to look for another issue to work on.
FWI worth, I am new to this repo.

Copy link

stale bot commented May 24, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label May 24, 2024
@stale stale bot closed this as completed May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

10 participants