Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaxConnectionsError not used consistently #3237

Open
PeterJCLaw opened this issue May 17, 2024 · 0 comments
Open

MaxConnectionsError not used consistently #3237

PeterJCLaw opened this issue May 17, 2024 · 0 comments

Comments

@PeterJCLaw
Copy link

PeterJCLaw commented May 17, 2024

Version: redis-py 5.0.4
Platform: Ubuntu 22.04

The docs around the max_connections argument in various places suggest that MaxConnectionsError should be used to indicate a lack of available connections, yet that exception type seems only to be used in one place:

raise MaxConnectionsError()

Other places use ConnectionError("Too many connections").

Is this expected? Should these all use MaxConnectionsError?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant