Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider BaseplateError exceptions with code=5xx an error for span accounting #606

Open
spladug opened this issue Aug 9, 2021 · 0 comments

Comments

@spladug
Copy link
Contributor

spladug commented Aug 9, 2021

We don't generally consider IDL-specified Thrift exceptions as span failures (since they're generally equivalent to a 4xx in HTTP terms -- they're part of a valid response rather than an indication the service failed). However, when we create BaseplateError exceptions with explicit 5xx error codes we should count those as service failures and set success=False in span accounting.

@spladug spladug changed the title Consider BaseplateError exceptions with code=5xx/6xx an error for span accounting Consider BaseplateError exceptions with code=5xx an error for span accounting Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant