Stringbuf warning when compiling

[reunite-ro]

rAthena Hash

5ebfd54

Client Date

not related

Server Mode

Pre-Renewal

Result

make[1]: Entering directory `/root/rathena/src/common'
MKDIR obj
CXX core.cpp
CXX socket.cpp
CXX timer.cpp
CXX db.cpp
CXX nullpo.cpp
CXX malloc.cpp
CXX showmsg.cpp
CXX strlib.cpp
strlib.cpp: In function ‘size_t _StringBuf_Vprintf(const char*, int, const char*, StringBuf*, const char*, __va_list_tag*)’:
strlib.cpp:1015:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
if( n > -1 && n < size )
~~^~~~~~
CXX utils.cpp

Relevant Log Output

No response

Expected Result

Maybe no warning if possible.

How to Reproduce

Recompile in Centos 7 environment, didnt tried yet with Ubuntu.

Official Information

not related

Modifications that may affect results

No response

[admkakaroto]

Some in Windows VS Commpiler.

[srogm]

Seeing this on Debain as well.
warning: comparison of integer expressions of different signedness: 'int' and 'size_t' {aka 'long unsigned int'} [-Wsign-compare]

[gmragnarok]

i have same issue

OS Configuration

CentOS Linux release 7.9.2009 (Core)
gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5)

Result

        CXX     showmsg.cpp
        CXX     strlib.cpp
strlib.cpp: In function ‘size_t _StringBuf_Vprintf(const char*, int, const char*, StringBuf*, const char*, __va_list_tag*)’:
strlib.cpp:1014:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   if( n > -1 && n < size )
                 ~~^~~~~~
        CXX     utils.cpp
        CXX     utilities.cpp

[Daegaladh]

Seems my PR works fine on Ubuntu
Could someone try on CentOS?

[aleos89]

I tested on an old CentOS 7 (gcc 7.3.1) I have and it compiled with no warnings.