Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples table to docs for toolbar controls #3642

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ Pull Requests modifying public facing interfaces or APIs, including backwards co
Pull requests must:

1. Be forked off the [develop](https://github.com/quilljs/quill/tree/develop) branch.
2. Pass the linter and conform to existing coding styles.
2. [Pass the linter](./DEVELOPMENT.md) and conform to existing coding styles.
3. Commits are [squashed](https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History#Squashing-Commits) to minimally coherent units of changes.
4. Are accompanied by tests covering the new feature or demonstrating the bug for fixes.
5. Serve a single atomic purpose (add one feature or fix one bug).
Expand Down
2 changes: 1 addition & 1 deletion .github/DEVELOPMENT.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Quill's source is in [ES6](http://www.ecma-international.org/ecma-262/6.0/index.html) and utilizes [Webpack](https://webpack.github.io/) to organize its files. The documentation site (hosted at [quilljs.com](https://quilljs.com/)) is built with [Jekyll](http://jekyllrb.com/). [Karma](https://karma-runner.github.io/) and [Protractor](https://angular.github.io/protractor/) are used for testing.

To develop Quill locally, you will want a copy of Quill's codebase, with the build pipeline and documentation site running locally. The documentation site lives in `doc/` but will use your local build instead of the CDN that the public site uses. This allows you to test changes on a local copy of all of the quilljs.com demos, such as the [standalone examples](https://github.com/quilljs/quill/blob/develop/docs/docs/standalone).
To develop Quill locally, you will want a copy of Quill's codebase, with the build pipeline and documentation site running locally. The documentation site lives in `doc/` but will need to use your local build instead of the CDN that the public site uses. This allows you to test changes on a local copy of all of the quilljs.com demos, such as the [standalone examples](https://github.com/quilljs/quill/blob/develop/docs/docs/standalone).


### Setup
Expand Down
51 changes: 50 additions & 1 deletion docs/assets/css/styles.css
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,15 @@ h2 + hr {
margin-top: 0;
}

details summary {
cursor: pointer;
display: list-item;
}

details summary > * {
display: inline;
}

/*** Global ***/

svg .logo {
Expand Down Expand Up @@ -1287,10 +1296,50 @@ body:not(.home) .navbar-link:before {
#content-container h6 {
margin-top: 2em;
}
#content-container table {
border-collapse: collapse;
}
#content-container table tr th,
#content-container table tr td {
border: 1px solid #d9dce1;
padding: 0.5em;
}
#content-container table tr td p:last-child {
margin-bottom: 0;
}
#content-container table tr td figure {
margin: 0;
margin-bottom: 1em;
vertical-align: middle;
}
#content-container table tr td figure:last-child {
margin-bottom: 0;
}
#content-container table tr td pre {
margin: 0;
}
#content-container table tr td pre > code {
padding: 0.5em;
}
#content-container table tr td details {
display: inline-block;
}
#content-container details {
border: 1px solid #f4f5f5;;
}
#content-container details summary {
font-weight: bold;
background: #f4f5f5;
padding: 0.5em 1em;
}
#content-container details table:last-child {
margin-bottom: 0;
}
#toolbar-toolbar {
margin-bottom: 2em;
}
#toolbar-editor {
#toolbar-editor,
#toolbar-controls-editor {
display: none;
}

Expand Down