Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: future v3 changes #642

Open
qdm12 opened this issue Feb 9, 2024 · 0 comments
Open

Feature request: future v3 changes #642

qdm12 opened this issue Feb 9, 2024 · 0 comments
Labels
Category: Label missing ❗ Status: 🔒 After next release Will be done after the next release

Comments

@qdm12
Copy link
Owner

qdm12 commented Feb 9, 2024

  • Remove ipv4 or ipv6 option since it's confusing. This is code breaking change due to the pkg/publicip packages, and removes a few options for the IP echo services
  • Remove provider_ip, since it's rather unneeded since the public ip is already known by the program and it would be more reliable to send it ourselves (especially to prevent the registrar server to assume the wrong Ip version)
  • Rename PUBLICIP* to PUBLICIP_ECHO_ for configuration keys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: Label missing ❗ Status: 🔒 After next release Will be done after the next release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@qdm12