Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT CLOSE IT / GitHub workflows / Access Rules #5132

Open
DanilBaibak opened this issue Apr 25, 2024 · 3 comments
Open

DO NOT CLOSE IT / GitHub workflows / Access Rules #5132

DanilBaibak opened this issue Apr 25, 2024 · 3 comments

Comments

@DanilBaibak
Copy link
Contributor

DanilBaibak commented Apr 25, 2024

In the FIRST comment you can specify who will use the linux foundation (LF) runners:

  • Add a GitHub username to use LF runners.
  • Add "*" at the beginning to switch ALL users to LF runners.
  • Add "!" at the beginning to switch ALL users to old runners.
@DanilBaibak
Copy link
Contributor Author

DanilBaibak commented Apr 25, 2024

atalman
clee2000
huydhn
izaitsevfb
jeanschmidt
DanilBaibak
kit1980
malfet
seemethere
ZainRizvi

@DanilBaibak DanilBaibak changed the title ARC dynamic rollout GitHub workflows / Dynamic Rollout May 6, 2024
@DanilBaibak DanilBaibak changed the title GitHub workflows / Dynamic Rollout GitHub workflows / Access Rules May 7, 2024
pytorchmergebot pushed a commit to pytorch/pytorch that referenced this issue May 10, 2024
This PR introduces a tool to dynamically switch between ARC runners and old runners without having to update the PR to the latest version.

There is also a third option - use both runners at the same time (aka shadow deployment). In this case, failed workflows using ARC launchers will not block merge process.

The GitHub issue is used to control access to ARC launchers - [Access Rules Issue](pytorch/test-infra#5132):

* In the FIRST comment you can specify who will use the ARC runners:
   * Add a GitHub username to use ARC runners.
   * Add "*" at the beginning to switch ALL users to ARC runners.
   * Add "!" at the beginning to switch ALL users to old runners.
* In the SECOND comment you can specify do we need to run ARC runners and old runners at the same time.
   * To use both runners, add a second comment with the word "both".
   * If we want to use only one type of runners, just remove the second comment.
Pull Request resolved: #125680
Approved by: https://github.com/ZainRizvi
@kit1980
Copy link
Member

kit1980 commented May 31, 2024

Should we close this?

@DanilBaibak DanilBaibak changed the title GitHub workflows / Access Rules DO NOT CLOSE IT / GitHub workflows / Access Rules Jun 3, 2024
@DanilBaibak
Copy link
Contributor Author

No, pls don't close the issue. It will be used for dynamic rollout while we are migrating from our runners to the linux foundation runners.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants