-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cancelled jobs on CI are still not handled correctly #4997
Comments
AI: Cancelled signals should be surface in clear way 1) if the job is cancel by user, we should tell that the merge is cancel 2) if the job is cancel because a higher priority job runs, it shouldn't show up as failures |
To clarify the ask, would it be correct to say we want:
|
The first point is correct, when the jobs are cancelled by the user, we want them to show up as failures and block merge. However, if the jobs are canceled by a higher priority request like the above example, we don't want them to shown up on Dr.CI though. Instead, we need to use the status of the newer set of jobs instead. |
IIRC if we just show cancelled jobs as cancelled, when the new job kicks off we'd automatically show the status of of the now-running job, right? |
Related Issue: #4644 |
Yeah, that's what I think too. This issue is kind of hard to track and reproduce. |
There are feedback that cancelled signals on CI are still showing up. This causes confusion and also blocks merge. For example, pytorch/pytorch#121522 (comment)
Looking at the workflow summary https://github.com/pytorch/pytorch/actions/runs/8207746512, it's clear that the workflow was cancelled by its concurrency rule:
If we can query this information, it should be a reliable way to handle cancelled signals on CI.
The text was updated successfully, but these errors were encountered: