Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto revert broken trunk commits #4994

Open
huydhn opened this issue Mar 8, 2024 · 2 comments
Open

Auto revert broken trunk commits #4994

huydhn opened this issue Mar 8, 2024 · 2 comments
Assignees

Comments

@huydhn
Copy link
Contributor

huydhn commented Mar 8, 2024

The number of force merges is on the raise recently and it's proportional to the increase in red trunk commits. In addition, we also had a CI sev in Feb where viable/strict wasn't updated for 5+ days pytorch/pytorch#120368. In both cases, handling broken trunk failures wasn't done in a timely manner. There are also some CI jobs where oncall might feel reluctant to revert right away without checking with the owner, for example rocm and inductor jobs.

The proposal here is to let the bot do it instead:

  1. The bot will post a comment if it considers a commit is breaking trunk and should be reverted. It's cc the author and PyTorch Dev Infra (oncall)
  2. If the revert is not needed, the author or oncall can reply to tell it to not do so, i.e. https://github.com/pytorch/ci-infra/pull/45#issuecomment-1961716433
  3. Otherwise, after waiting for X hours, the bot will revert the change
  4. [Optional] If the revert doesn't help and similar failures still occur in trunk, the bot could reland the reverted change providing that the necessary approval is still there.

cc @clee2000 @kit1980 @PaliC @malfet @seemethere

@huydhn
Copy link
Contributor Author

huydhn commented Mar 11, 2024

Some further thoughts from the team:

  • We should clearly define the condition when the bot could do the revert:
    • Not a CI sev
    • Not an upstream failures, i.e. conda
  • It's a good idea to cap the limit of reverts the bot could do within a period of time

@huydhn
Copy link
Contributor Author

huydhn commented Mar 12, 2024

AI: Add a filter to HUD to zoom in the streak of failures on HUD that is associated with the reverts

@huydhn huydhn self-assigned this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant