Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picker URL parameters are not updated for TorchInductor benchmarks #4926

Open
xmfan opened this issue Feb 5, 2024 · 0 comments
Open

Picker URL parameters are not updated for TorchInductor benchmarks #4926

xmfan opened this issue Feb 5, 2024 · 0 comments

Comments

@xmfan
Copy link
Member

xmfan commented Feb 5, 2024

The URL is encoding the default values of each picker value, but is not updated when new picker values are selected. As a result, we would need to renavigate to the desired view every time we want to access a saved link.

e.g. https://hud.pytorch.org/benchmark/torchbench/inductor_no_cudagraphs?startTime=Mon,%2029%20Jan%202024%2019:45:09%20GMT&stopTime=Mon,%2005%20Feb%202024%2019:45:09%20GMT&granularity=hour&mode=training&dtype=amp&lBranch=main&lCommit=8f82a44a5beed0f205a7f273b9f062da43d65679&rBranch=main&rCommit=47b5a6b05d00e91182ee3c4a62f9b94e2d21b4eb

Updating some picker values e.g. branch, and link remains the same. Opening the link again/Refreshing the page will lose the picker states
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant