Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v0.2.0] Release Tracker #2666

Closed
guangy10 opened this issue Mar 25, 2024 · 92 comments
Closed

[v0.2.0] Release Tracker #2666

guangy10 opened this issue Mar 25, 2024 · 92 comments
Labels
triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@guangy10
Copy link
Contributor

guangy10 commented Mar 25, 2024 •
edited by dbort

The v0.2.0 release has been cut, and this issue is closed. Use #3409 for cherry-picking into the v0.2.1 release.

v0.2.0 release branch was cut. The branch name is "release/0.2", with tag "v0.2.0-rc4" atm.

Our release plan from this point is roughly:

  • Phase 1 (until 4/5/24):
    -- work on finalizing the release branch for stability for soft-launch.
    -- initial set of documentations and reproducible instructions, including Llama.
    -- apply release-branch specific changes (changes not in main but directly in release/0.2 branch like pins).
    -- Coordinate with PyTorch v2.3 release milestones, and prioritize to get PyTorch PRs needed by ExecuTorch v0.2.0 cherry-picked into PyTorch release v2.3.0. It will be very hard to do so after 04/01.

  • Phase 2 (after 4/5/24, until 4/24/24 by 12:00pm PDT):
    -- perform extended integration/stability/performance testing based on Release Candidate builds.
    -- fix critical bugs based on early feedback from our soft-launch
    -- enhance our documentation.

This issue is for tracking cherry-picks to the release branch.

Cherry-Pick Criteria

Focus on stability. Ideally only low risk changes may be cherry-picked from main:

  1. Critical fixes in core components: build, exir, backends, runtime, sdk
  2. Bug fixes in demos/examples. No new features/experiments
  3. Critical bug fixes based on community feedback
  4. Documentation improvements
  5. Test/CI fixes
  6. Release branch specific changes (e.g. change version identifiers)

Any core components changes and other change will require special dispensation from the release managers (currently @guangy10 @mergennachin @dbort ). If this applies to your change please write "Special Dispensation" in the "Criteria Category:" template below and explain.

Cherry-Pick Process

  1. Ensure your PR has landed in master. This does not apply for release-branch specific changes (see Phase 1 criteria).

  2. Create (but do not land) a PR against the release branch.
    Option 1: Use pytorchbot to cherry pick a PR that has been committed to the main branch using @pytorchbot cherry-pick command as follows.

    @pytorchbot cherry-pick --onto release/0.2 -c {regression,critical,fixnewfeature,docs,release}

    usage: @pytorchbot cherry-pick --onto ONTO [--fixes FIXES] -c
                         {regression,critical,fixnewfeature,docs,release}

Cherry pick a pull request onto a release branch for inclusion in a release

optional arguments:
  --onto ONTO           Branch you would like to cherry pick onto (Example: release/0.2)
  --fixes FIXES         Link to the issue that your PR fixes (i.e. https://github.com/pytorch/executorch/issues/2345)
  -c {regression,critical,fixnewfeature,docs,release}
                  A machine-friendly classification of the cherry-pick reason.

    Option 2: Manually create a cherry pick PR using git command as follows.

    # Find the hash of the commit you want to cherry pick
# (for example, abcdef12345)
git log

git fetch origin release/0.2
git checkout release/0.2
git cherry-pick -x abcdef12345

# Submit a PR based against 'release/0.2' either:
# via the GitHub UI
git push my-fork

# via the GitHub CLI
gh pr create --base release/0.2

  3. Make a request below with the following format:

Link to landed trunk PR:
* 

Link to release branch PR:
* 

Criteria category and reasons:
*
  1. Someone from the release team will reply with approved / denied or ask for more information.
  2. If approved, someone from the release team will merge your PR once the tests pass. Do not land the release branch PR yourself.

Please note HUD Link with branch CI status and link to the HUD to be provided here.
HUD

Versions

0.2.0
@guangy10 guangy10 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Mar 25, 2024
@mergennachin mergennachin pinned this issue Mar 26, 2024
@GregoryComer
Copy link
Member

GregoryComer commented Mar 28, 2024 •
edited by guangy10

Link to landed trunk PR:

Link to release branch PR:

Criteria category and reasons:

  • Docs: Restore build instructions in CMakeLists.txt top-level comment.

@guangy10 merged via fast-forward.

@YifanShenSZ YifanShenSZ mentioned this issue Mar 31, 2024
Merged
mergennachin referenced this issue Apr 8, 2024
@shoumikhin @facebook-github-bot
Update docs for the demo app. (#2921)
9ba8bc9 
Summary:
Pull Request resolved: #2921
overriding_review_checks_triggers_an_audit_and_retroactive_review
Oncall Short Name: executorch

Differential Revision: D55885790

fbshipit-source-id: bb62a42b74ecdfb2e1f6bcebab979e2e8fcf0a3c
@kirklandsign
Copy link
Contributor

kirklandsign commented Apr 8, 2024 •
edited by guangy10

Link to landed trunk PR:

Link to release branch PR:

Criteria category and reasons:

  • Documentation improvements. Better readability for markdown.

@guangy10 merged

@kirklandsign
Copy link
Contributor

kirklandsign commented Apr 8, 2024 •
edited by guangy10

Link to landed trunk PR:

Link to release branch PR:

Criteria category and reasons:

  • Documentation improvements. For Android, only use path /data/local/tmp/llama to avoid confusion.

@guangy10 merged

@GregoryComer
Copy link
Member

GregoryComer commented Apr 9, 2024 •
edited by mergennachin

Link to landed trunk PR:

Link to release branch PR:

Criteria category and reasons:

  • Documentation improvements and critical fixes for LLM getting started guide.

@mergennachin merged

@mergennachin
Copy link
Contributor

mergennachin commented Apr 9, 2024 •
edited

Link to landed trunk PR:

Link to release branch PR:

Criteria category and reasons:

  • Update documentation for Llama2

@mergennachin merged

@mergennachin
Copy link
Contributor

mergennachin commented Apr 9, 2024 •
edited

Link to landed trunk PR:

Link to release branch PR:

Criteria category and reasons:

  • Update documentation fix for Llama2

@mergennachin merged

@mergennachin
Copy link
Contributor

mergennachin commented Apr 9, 2024 •
edited

Link to landed trunk PR:

Link to release branch PR:

Criteria category and reasons:

  • Update documentation for Llama2

@mergennachin merged

@mergennachin
Copy link
Contributor

mergennachin commented Apr 9, 2024 •
edited

Link to landed trunk PR:

Link to release branch PR:

Criteria category and reasons:

  • Fix speed generation calculation for iLlama app

@mergennachin merged

@cccclai
Copy link
Contributor

cccclai commented Apr 9, 2024 •
edited by mergennachin

Link to landed trunk PR:

Link to release branch PR:

Criteria category and reasons:
Exclude mutable buffers in constant tagging

@mergennachin merged

@GregoryComer
Copy link
Member

GregoryComer commented Apr 10, 2024 •
edited by guangy10

Link to landed trunk PR:

Link to release branch PR:

Criteria category and reasons:

  • Documentation updates to LLM getting started guide to fix blockers in ExecuTorch installation on mac when not using Conda. Minor other doc fixes.

——-
@guangy10 merged

@GregoryComer
Copy link
Member

GregoryComer commented Apr 10, 2024 •
edited by mergennachin

Link to landed trunk PR:

Link to release branch PR:

Criteria category and reasons:

  • Support auto-downloading buck from CMake on Intel Macs. Needed to streamline CMake builds in OSS, since without this, users will have to download the appropriate version of buck2 and explicitly pass in the path.

@mergennachin merged

@Olivia-liu
Copy link
Contributor

Olivia-liu commented Apr 10, 2024 •
edited by guangy10

Link to landed trunk PR:

Link to release branch PR:

Criteria category and reasons:

  • Doc changes, refine The LLM Manual

@guangy10 merged

@mergennachin
Copy link
Contributor

mergennachin commented Apr 11, 2024 •
edited by guangy10

Link to landed trunk PR:

Link to release branch PR:

Criteria category and reasons:

  • Doc improvement

@guangy10 merged

@kirklandsign
Copy link
Contributor

kirklandsign commented Apr 11, 2024 •
edited by guangy10

Link to landed trunk PR:

Link to release branch PR:

Criteria category and reasons:

  • Bug fixes in demos/examples + Documentation improvements.

@guangy10: @kirklandsign which PR you're request cherry-picking from trunk? Can you make one cherry-pick request per PR? It's okay to squash multiple doc-only changes in one cherry-pick, but please do not mix doc improvement with bug fixes or feature improvement.

@kirklandsign: @guangy10 OK let me separate them.

#2934 is used for QNN fix, but it broke CI and needs #2956 #3006 for CI fix.

@kirklandsign I'm still confused which PRs are cherry-picking PR, and which PR it's mapped in the trunk. Can you please make sure you cherry-picking request is organized as other requests above?
Also why is a cherry-picking PR titled release-only? Release-only means the changes should not land in main hence called "release-only".

@kirklandsign: #3025 is the CP in release branch, and it maps into #2934, #2956, #3006 because #2934 caused CI failure. Also note that #3006 is not a clean cherry-pick, because it fixes some other stuff in main branch only.

@guangy10 merged

@Olivia-liu
Copy link
Contributor

Olivia-liu commented Apr 11, 2024 •
edited by guangy10

Link to landed trunk PR:

Link to release branch PR:

Criteria category and reasons:

  • Add a missing import in the LLM manual doc

@guangy10 merged

@cccclai
Copy link
Contributor

cccclai commented Apr 11, 2024 •
edited by guangy10

Link to landed trunk PR:
#2957

Link to release branch PR:

#3051

Criteria category and reasons:

Fix qnn quantizer when it tries to quantize non fp32 tensor

@guangy10 : @cccclai is it a critical bug fix? I'm not sure how qnn stuff can be well tested since there is no test/CI for it.

@cccclai: it's required for the stories llama model runnning end to end with qnn backend. It needs to be manual test unfortunately. The .so library needs to be downloaded from qualcomm website required user name and password

@kirklandsign: If #2999 is needed, could you please fix the linter in https://github.com/pytorch/executorch/pull/2999/files ? This will become a non-clean-CP but needed for linter. Then I can safely CP #3006 either with or without #2999 in release branch.

@cccclai: good call - let me fix it

@guangy10: @cccclai there is a linter failure in the cherry-pick PR. If it's fixed already in other PR, please rebase and let me know when it's ready to merge
@cccclai : updated the pr and the linter failure is fixed

@guangy10 merged

@kirklandsign kirklandsign reopened this Apr 12, 2024
@kirklandsign
Copy link
Contributor

kirklandsign commented Apr 12, 2024 •
edited by guangy10

Link to landed trunk PR:

Link to release branch PR:

Criteria category and reasons:

@guangy10 merged

@kirklandsign
Copy link
Contributor

kirklandsign commented Apr 12, 2024 •
edited by guangy10

Link to landed trunk PR:

Link to release branch PR:

Criteria category and reasons:

@guangy10 merged

@Gasoonjia
Copy link
Contributor

Gasoonjia commented Apr 15, 2024 •
edited by guangy10

Link to landed trunk PR:
#2973

Link to release branch PR:

#3042

Criteria category and reasons:

Doc changes, refine The LLM Manual

@guangy10 : @Gasoonjia you have a linter error to fix

@guangy10 merged

@cccclai
Copy link
Contributor

cccclai commented Apr 16, 2024 •
edited by guangy10

Link to landed trunk PR:
#3005

Link to release branch PR:

#3052

Criteria category and reasons:

Getting ready to push the changes to enable running stories end to end for qnn backend. Other prs includes #3007, #3036, #3037, #3038 (the last pr for qnn). Will submit merged PRs accordingly when this one merges

@guangy10 merged

@cccclai
Copy link
Contributor

cccclai commented Apr 16, 2024 •
edited by guangy10

Link to landed trunk PR:
#3007

Link to release branch PR:

#3061

Criteria category and reasons:

Getting ready to push the changes to enable running stories end to end for qnn backend. #3005 is merged, this is the second pr. Remaining ones are #3036, #3037, #3038 (the last pr for qnn). Will submit merged PRs accordingly when this one merges

@guangy10 merged

@svekars
Copy link
Contributor

svekars commented Apr 17, 2024 •
edited by guangy10

Link to landed trunk PR:
#3045

Link to release branch PR:

#3098

Criteria category and reasons:

Doc build fix. This one needs to be cherry-picked before #3099.

@guangy10 merged

@svekars
Copy link
Contributor

svekars commented Apr 17, 2024 •
edited by guangy10

Link to landed trunk PR:

#3071

Link to release branch PR:

#3099

Criteria category and reasons:

Doc build fix. This one needs to be cherry-picked after #3098.

@guangy10 merged

@cccclai
Copy link
Contributor

cccclai commented Apr 18, 2024 •
edited by guangy10

Link to landed trunk PR:
#3036

Link to release branch PR:

#3114

Criteria category and reasons:

Remaining changes to enable qnn are #3037, #3038. Will submit merged PRs accordingly when this one merges

@guangy10 merged

@shoumikhin
Copy link
Contributor

shoumikhin commented Apr 24, 2024 •
edited by dbort

Obsoleted by #2666 (comment) (cherry-pick PR #3327) below

Link to landed trunk PR:

  • [placeholder]

Link to release branch PR:

  • [placeholder]

Criteria category and reasons:

@larryliu0820
Copy link
Contributor

larryliu0820 commented Apr 24, 2024 •
edited by guangy10

Link to landed trunk PR:

#3320

Link to release branch PR:

#3330

Criteria category and reasons:

docs

@guangy10 merged

@shoumikhin
Copy link
Contributor

shoumikhin commented Apr 24, 2024 •
edited by guangy10

Link to landed trunk PR:
#3322
#3325

Link to release branch PR:
[placeholder]

Criteria category and reasons:
Docs

@guangy10: @shoumikhin please correct the link. I think 3322 is not needed. 3325 is merged. Could you confirm?

@Gasoonjia
Copy link
Contributor

Gasoonjia commented Apr 24, 2024 •
edited by guangy10

Link to landed trunk PR:

Link to release branch PR:

Criteria category and reasons:

  • Doc fix: bring buck2 installation back to unblock user running buck2 examples

@guangy10 merged

@dbort
Copy link
Contributor

dbort commented Apr 24, 2024 •
edited by guangy10

Link to landed trunk PR:

  • None; I will cherry-pick this back to main later

Link to release branch PR:

Criteria category and reasons:

  • Update README-wheel.md to document pybindings restrictions (which backends and operators are linked in)

@guangy10 merged

@mergennachin
Copy link
Contributor

mergennachin commented Apr 24, 2024 •
edited by guangy10

Link to landed trunk PR:

  • N/A

Link to release branch PR:

Criteria category and reasons:

  • Documentation to reflect checking out latest stable branch

@guangy10 merged

@dbort
Copy link
Contributor

dbort commented Apr 24, 2024

Apart from the existing placeholders, we are not taking any more cherry-picks for this RC. Once those placeholders are resolved and merged, we will make the cut.

@guangy10
Copy link
Contributor Author

We will focus on getting pending CR above merged then do the cut. New cherry-pick beyond this point will not be merged for the final RC.

If it's critical bug fix, it will need to wait for the batch merge for the final RC before launch.

@DenisVieriu97
Copy link
Collaborator

DenisVieriu97 commented Apr 24, 2024 •
edited

Link to landed trunk PR:

Link to release branch PR:

Criteria category and reasons:

  • Documentation improvements to reflect latest MPS changes.

cc @dbort, @guangy10

@DenisVieriu97
Copy link
Collaborator

DenisVieriu97 commented Apr 24, 2024 •
edited by guangy10

Link to landed trunk PR:

Link to release branch PR:

Criteria category and reasons:

  • Critical bug fix breaking MPS AOT Tracing

cc @dbort , @guangy10

@shoumikhin Is this a dup of this request #2666 (comment)?

@shoumikhin
Copy link
Contributor

@shoumikhin Is this a dup of this request #2666 (comment)?

@DenisVieriu97 if it resolved the CI check https://github.com/pytorch/executorch/actions/runs/8822790798 then yes!

@DenisVieriu97
Copy link
Collaborator

@DenisVieriu97 if it resolved the CI check https://github.com/pytorch/executorch/actions/runs/8822790798 then yes!

Thanks @shoumikhin . test-demo-ios has passed for that PR run. test-demo-ios will fail in #3329 as it was merged before the PR with the fix, but that branch has only MPS doc changes which succeeded in building (cc @guangy10).

@Olivia-liu
Copy link
Contributor

Olivia-liu commented Apr 24, 2024 •
edited by dbort

Link to landed trunk PR:

Link to release branch PR:

Criteria category and reasons:

  • Doc fixes

@guangy10 merged

@mergennachin
Copy link
Contributor

Link to landed trunk PR:

  • N/A

Link to release branch PR:

Criteria category and reasons:

  • Update performance numbers

@mergennachin merged

@guangy10
Copy link
Contributor Author

No outstanding cherry-picks.
Done creating the "v0.2.0-rc4" tag and kicked off prebuilt binaries from this tag.

@mergennachin
Copy link
Contributor

mergennachin commented Apr 25, 2024 •
edited

Link to landed trunk PR:

Link to release branch PR:

Criteria category and reasons:

  • Disclaimer

@mergennachin merged

@dbort
Copy link
Contributor

dbort commented Apr 25, 2024 •
edited

Link to landed trunk PR:

Link to release branch PR:

Criteria category and reasons:

  • Fixes tag pattern matching to trigger docs build/push

@dbort merged

@dbort
Copy link
Contributor

dbort commented Apr 25, 2024 •
edited

Link to landed trunk PR:

Link to release branch PR:

Criteria category and reasons:

  • Fix flaky macos wheel builds

@dbort merged

@svekars
Copy link
Contributor

svekars commented Apr 25, 2024 •
edited by dbort

Link to landed trunk PR:

Link to release branch PR:

Criteria category and reasons:

  • Doc build fix

@mergennachin merged

@dbort
Copy link
Contributor

dbort commented Apr 25, 2024 •
edited

Link to landed trunk PR:

Link to release branch PR:

Criteria category and reasons:

  • Reword the "Preview only" message at the top of the ET website. Instead say that this is an alpha release and that the .pte format and APIs may change in a breaking way before Beta, later in 2024

@dbort merged

@dbort
Copy link
Contributor

dbort commented Apr 25, 2024 •
edited

Link to landed trunk PR:

Link to release branch PR:

Criteria category and reasons:

  • Fixes tag pattern matching to trigger docs build/push

@dbort merged

@mergennachin
Copy link
Contributor

mergennachin commented Apr 26, 2024 •
edited

Link to landed trunk PR:

Link to release branch PR:

Criteria category and reasons:

  • Arm documentation fixes

@mergennachin merged

@mergennachin mergennachin mentioned this issue Apr 26, 2024
Merged
@mergennachin
Copy link
Contributor

mergennachin commented Apr 26, 2024 •
edited

Link to landed trunk PR:

Link to release branch PR:

Criteria category and reasons:

  • README documentation

@mergennachin merged

@dbort
Copy link
Contributor

dbort commented Apr 26, 2024 •
edited

No more outstanding cherry-picks. I plan to create the v0.2.0-rc5 tag against 4f79832, the current release/0.2 HEAD

Done: https://github.com/pytorch/executorch/releases/tag/v0.2.0-rc5

@svekars
Copy link
Contributor

svekars commented Apr 27, 2024 •
edited by dbort

Link to landed trunk PR:

Link to release branch PR:

Criteria category and reasons:

  • Doc build fix

@dbort merged. Note that this doesn't need to be in the tagged RC/release to still be helpful.

@dbort
Copy link
Contributor

dbort commented Apr 29, 2024

The v0.2.0 release has been cut, and this issue is closed. Use #3409 for cherry-picking into the v0.2.1 release.

@dbort dbort closed this as completed Apr 29, 2024
@dbort dbort unpinned this issue Apr 29, 2024
@Gasoonjia Gasoonjia mentioned this issue May 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests