Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix model_flops feature on PT2 #2131

Open
xuzhao9 opened this issue Jan 23, 2024 · 1 comment
Open

Fix model_flops feature on PT2 #2131

xuzhao9 opened this issue Jan 23, 2024 · 1 comment

Comments

@xuzhao9
Copy link
Contributor

xuzhao9 commented Jan 23, 2024

Now the flops counter is broken, need to fix it and add a test to prevent future issues.

Run command:

buck2 run @mode/opt //pytorch/benchmark:run -- resnet50 -d cuda -t train --metrics model_flops --torchdynamo inductor

or

python run.py resnet50 -d cuda -t train --metrics model_flops  --torchdynamo inductor
@xuzhao9 xuzhao9 changed the title Fix model_flops feature Fix model_flops feature on PT2 Jan 26, 2024
@xuzhao9
Copy link
Contributor Author

xuzhao9 commented Jan 26, 2024

We should also add a test internally to guard on this use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant