Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to macos-latest (arm64) in ci #12327

Open
OrKoN opened this issue Apr 25, 2024 · 5 comments
Open

Switch to macos-latest (arm64) in ci #12327

OrKoN opened this issue Apr 25, 2024 · 5 comments
Labels

Comments

@OrKoN
Copy link
Collaborator

OrKoN commented Apr 25, 2024

See #12326

@OrKoN OrKoN added the feature label Apr 25, 2024
@OrKoN OrKoN changed the title Switch to macos-latest (arm64) Switch to macos-latest (arm64) in ci Apr 25, 2024
@smoya
Copy link

smoya commented Jun 4, 2024

Could you provide more details about the reason you downgraded from macos-latest (macos-14, atm64) to macos-13?
I didn't make it to run puppeteer in macos-14 so that's how I came to this issue. Is Puppeteer officially not supporting macos-14 ?

Thanks

@OrKoN
Copy link
Collaborator Author

OrKoN commented Jun 4, 2024

We do support Puppeteer on mac arm64 but there are some issues on the Github Actions runners. We had a few test failures in Chrome as seen here https://github.com/puppeteer/puppeteer/actions/runs/9356693211/job/25754758510?pr=12328 (not reproducible on local mac arm64 devices) but also Firefox could not be run on macos-latest for some reason (https://bugzilla.mozilla.org/show_bug.cgi?id=1893921)

@smoya
Copy link

smoya commented Jun 5, 2024

We do support Puppeteer on mac arm64 but there are some issues on the Github Actions runners. We had a few test failures in Chrome as seen here https://github.com/puppeteer/puppeteer/actions/runs/9356693211/job/25754758510?pr=12328 (not reproducible on local mac arm64 devices) but also Firefox could not be run on macos-latest for some reason (https://bugzilla.mozilla.org/show_bug.cgi?id=1893921)

I guess then you recommend downgrading to macos-13 in the meantime?

@OrKoN
Copy link
Collaborator Author

OrKoN commented Jun 5, 2024

It is probably a good idea for now, once Firefox is able to run on Github Actions runners we would go back to macos-latest. Note that on local macos-14 arm64 devices we do not experience this issue but so far it is not clear what causes it on Github Actions runners.

@OrKoN
Copy link
Collaborator Author

OrKoN commented Jun 5, 2024

@smoya although perhaps you could isolate the failure that you see and file a bug report in case it is happening with Chrome? I am not sure that our test suite has the same failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants