implement programmatic default providers based on context in the engine and Go #16204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2024-05-24)Features
|
tgummerer
force-pushed
the
tg/default-providers-take-2
branch
3 times, most recently
from
f34ca8e
to
7f9200a
Compare
Frassle
reviewed
May 17, 2024
tgummerer
force-pushed
the
tg/default-providers-take-2
branch
6 times, most recently
from
4451116
to
ab691c3
Compare
Frassle
reviewed
May 23, 2024
tgummerer
force-pushed
the
tg/default-providers-take-2
branch
from
ab691c3
to
5b7821c
Compare
…ne and Go This PR takes an alternative approach for implementing programmatic default providers, that was suggested in the internal design doc. Instead of making the default provider global, we create an API with a callback that creates a new subcontext. In that subcontext and only in that subcontext is the provider set as the default provider. We achieve this by setting up a new monitor with a different port, so the engine can distinguish between the contexts.
tgummerer
force-pushed
the
tg/default-providers-take-2
branch
2 times, most recently
from
e64b47f
to
f20b7ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes an alternative approach for implementing programmatic default providers, that was suggested in the internal design doc.
Instead of making the default provider global, we create an API with a callback that creates a new subcontext. In that subcontext and only in that subcontext is the provider set as the default provider. We achieve this by setting up a new monitor with a different port, so the engine can distinguish between the contexts.
/xref #2059
Fixes #16169
Fixes #16163
Checklist
make tidyto update any new dependenciesmake lintto verify my code passes the lint checkgofumptmake changelogand committed thechangelog/pending/<file>documenting my change