Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tree Node Drag & Drop Keyboard Support #6631

Closed
nitrogenous opened this issue May 16, 2024 · 3 comments · Fixed by #6646
Closed

Tree Node Drag & Drop Keyboard Support #6631

nitrogenous opened this issue May 16, 2024 · 3 comments · Fixed by #6646
Assignees
@KirilCycle
Labels
Type: Bug Issue contains a defect related to a specific component.

Comments

@nitrogenous
Copy link
Member

I faced an issue when the Tree items became draggable, the keyboard keys were not working well (up, down, left, right, space, enter)
Can anyone no why? is it something that I'm doing wrong? I see it's either not working in the website example (primereact.org/tree/#dragdrop)

https://github.com/orgs/primefaces/discussions/1883
@nitrogenous nitrogenous added the Type: Bug Issue contains a defect related to a specific component. label May 16, 2024
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 16, 2024
@nitrogenous nitrogenous removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 16, 2024
@KirilCycle
Copy link
Contributor

KirilCycle commented May 17, 2024 •
edited

For some reason focus appear on droppoint element, I've seen that primeang DragDrop Tree works well, it's worth taking a look at their codebase. I want to fix this

@nitrogenous
Copy link
Member Author

Feel free to take it! @KirilCycle

@KirilCycle
Copy link
Contributor

KirilCycle commented May 20, 2024 •
edited

Yes, I will open a PR soon

@KirilCycle KirilCycle mentioned this issue May 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KirilCycle KirilCycle

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix 6631 DragDrop Tree keyboard navigation KirilCycle/primereact
2 participants
@nitrogenous @KirilCycle