Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] TST Tab Search extension no longer works correctly with TST #3531

Closed
miltuss opened this issue Apr 15, 2024 · 8 comments
Closed

[Bug] TST Tab Search extension no longer works correctly with TST #3531

miltuss opened this issue Apr 15, 2024 · 8 comments
Labels
bug extension-compatibility conflict with another addon help wanted stale no reaction got for a long term

Comments

@miltuss
Copy link

miltuss commented Apr 15, 2024

Hello, TST Tab Search no longer works correctly with the latest TST and Firefox updates. the tabs are not fully displayed, leaving a large gap at the bottom of the browser when searching. The bottom tabs disappear after scrolling. Would it be possible to correct this bug?

@piroor
Copy link
Owner

piroor commented Apr 15, 2024

Please give more information filling the issue template. Screenshots may help more researching.

@miltuss
Copy link
Author

miltuss commented Apr 16, 2024

My list of tabs is long as indicated by the scroll bar on the left, but when I search with the TST Tab Search extension, the tabs appear at the very top, and if I scroll up the tabs on the bottom disappear into the void.

image

The extension no longer appears to have the bottom TST boundary marker. It worked very well before but for a month I have had this problem under all my LibreWolf 124.0.1-1 and Firefox 124.0.2 browsers. I tested version 4.0.13 of TST (from the Firefox store) and version 4.0.8 downloaded from the github repository. I also tested version 0.0.7 of TST Tab Search (from the Firefox store) and also the development version 0.0.7b41 from the github. But the problem remains the same

I tested this with several Librewolf and Firefox instances under Linux-Mint 21.3

@piroor piroor added the extension-compatibility conflict with another addon label Apr 16, 2024
@miltuss
Copy link
Author

miltuss commented Apr 23, 2024

@piroor Hello, I have not received a response from you, do you plan to correct this bug please?

@piroor
Copy link
Owner

piroor commented Apr 30, 2024

Sadly there is no fundamental solution on TST side, because TST 4.0 and later won't render tabs out of the viewport and tabs under collapsed trees. TST Tab Search needs to be updated to work correctly:

  • Expand all trees while searching.
  • Hide all unmached tabs while searching. In other words, "shrink unmatched tabs" mode needs to be dropped.

@piroor
Copy link
Owner

piroor commented Apr 30, 2024

Sorry I missed that "Expand all trees while searching" is already done. TST Tab Search just need to hide unmached tabs via browser.tabs.hide() instead of CSS hack.

@piroor
Copy link
Owner

piroor commented Apr 30, 2024

See also: NiklasGollenstede/tst-search#34

@github-actions github-actions bot added the stale no reaction got for a long term label May 24, 2024
Copy link

This issue has been labeled as "stale" due to no response by the reporter within 1 month (and 7 days after last commented by someone). And it will be closed automatically 14 days later if not responded.

Copy link

github-actions bot commented Jun 8, 2024

This issue has been closed due to no response within 14 days after labeled as "stale", 7 days after last reopened, and 7 days after last commented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug extension-compatibility conflict with another addon help wanted stale no reaction got for a long term
Projects
None yet
Development

No branches or pull requests

2 participants