Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizer: refactor outer to inner join conversion as a separate rule #53278

Closed
ghazalfamilyusa opened this issue May 14, 2024 · 0 comments
Closed

Comments

@ghazalfamilyusa
Copy link
Contributor

Enhancement

Currently, the outer to inner join rewrite is part of the predicate push down. This is causing confusion and difficulty in extending of both rewrites. Also, the current implementation of outer to inner join rewrite has unnecessary special cases and error prone. Also, the unit test cases currently are very limited and we need more coverage of the scope.

Details

The enhancement will basically accomplish the following:

  • Create a new rule "outer_to_inner_join" and add it to the logical optimizations rule set. The rule is indepedent of the predicate push down and precedes it since it can trigger it.
  • Simplify the logic for AND/OR predicates and remove special cases.
  • Detailed unit test that covers all scenarios.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant