Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whats about a Discord Channel for Contributers? #1022

Open
scheilch opened this issue Feb 11, 2022 · 10 comments
Open

Whats about a Discord Channel for Contributers? #1022

scheilch opened this issue Feb 11, 2022 · 10 comments
Labels
question Further information is requested

Comments

@scheilch
Copy link
Contributor

scheilch commented Feb 11, 2022

It would be awesome to get in direct contact with you (the repository owners) for answering important questions.
For example:
Which source for logos do you use? <- is essentially for chosing correct service2logo relation
Where to request logo updates (for outdated logos) or create new ones (for missing - especially hd channels)
What kind of logo is accepted? (The one which is shown on the channel? What about radio channels - there is nothing shown.)
Why does nobody update the logo in srp file when a outdated logo was updated? (example: skyone has no hd in its logo even it is a hd channel but un the srp file are many entries with skyonehd)

It would make things much easier for new contributers to know how this project works.

@scheilch scheilch added the update Logo updates or additions to *.index label Feb 11, 2022
@Lexzie
Copy link
Member

Lexzie commented Feb 11, 2022

I'm quite a fan of Discord, so I could setup a server/channel for this.
Anyone can decide to join or not.

But I first can answer some questions for you.

Which source for logos do you use?

With satellite stations I check on Lyngsat where the same station is receivalble, and follow the link to their website.
On the website you can see which logo they use and sometimes one with good quality can be found there, but the most successful is Logopedia and sometimes Wikipedia.
Also a Google image search will get you results. Also try adding the option filetype:svg in a google search to find vector images, which we highly prefer.

Where to request logo updates (for outdated logos) or create new ones (for missing - especially hd channels)

Well just asking here with an issue to update a logo without doing some work yourself won't get people enthusiastic.
Try to find a logo and try to skill yourself in editing the logo to our requirements. There's lots to know and learn what our requirements are, most is explained in CONTRIBUTING.md.
Also a good idea to discuss that on a Discord channel. (Give me a few days and I'll have one setup).

What kind of logo is accepted? (The one which is shown on the channel? What about radio channels - there is nothing shown.)

This one is a little bit grey area. I personally choose to go with the logo shown on screen but in color, if the logo f.e. on the website is in color. The best is when a logo is visible on a dark and a light background. If not, you'll have to commit two logos, the default one and the one visible on a light or dark background depending on the default logo (never both dark and light and always a default logo!).
Special HD logos make the picon mostly less visible because mostly it makes the logo smaller. So if a channel is not using a specific HD logo and especially if I cannot find one, I rather use one logo for both the HD and the SD channel.
Eventually I believe stations will drop their SD channel and mostly also drop HD from their logo.
For radio channels you check their website.

Why does nobody update the logo in srp file when a outdated logo was updated? (example: skyone has no hd in its logo even it is a hd channel but un the srp file are many entries with skyonehd)

I don't know exactly what you mean with this question, when I add a srp-link and there is already an (old) link with the same srp I always delete the old one. This is not mandatory, but good practice if you do it.
If a new logo is committed and there is no separate HD-logo anymore it would be a good idea to change all the links to the (old) HD-logo to the new default logo. Not everyone (including me) will do that automatically,
Also i myself use the snp.index, so if I maintain the srp,index you're lucky.

There's a lot more to discuss and to explain, but this is it for now.

@AbuBaniaz
Copy link
Contributor

I think it is best to use the logo that looks best on the receiver when you activate the info bar, grid epg etc. Not necessarily the one that is on the website or tv.

The way the project works is that the entries at top of file are used. Historically, the redundant ones are just left there. IMO, best to delete them, but this is not a requirement.

If there are incorrect linkages, please supply correct ones. I though most people use SNP picons apart from ATV users where most of their skins use custom picon renderers instead of the one the image.

@Lexzie
Copy link
Member

Lexzie commented Feb 11, 2022

I have already a Discord running but I need to set it up for anyone who wants to join.

@scheilch
Copy link
Contributor Author

I'm sure there is a possibility to create a channel where everyone can join who has a Discord account. You just have to put the URL in the wiki.

@Lexzie
Copy link
Member

Lexzie commented Feb 11, 2022

Yes I know, I will let you know.
Right now busy with other things.

@Lexzie
Copy link
Member

Lexzie commented Feb 16, 2022

Quick update: I'm almost done but I still need to check things with my co-admin.
Keep in mind it's not affiliated to this Github and we like to keep it light there.

@Lexzie
Copy link
Member

Lexzie commented Mar 3, 2022

My co-admin was busy last week, so still work in progress.

@Lexzie
Copy link
Member

Lexzie commented Apr 13, 2022

I'm doing the last checks now on the channel, I will e-mail you the invite.

@Lexzie Lexzie closed this as completed Apr 13, 2022
@mrhotio
Copy link
Member

mrhotio commented Jul 17, 2022

Is there still a need for discord?? More than happy to add a channel on my discord https://hotio.dev/discord

@mrhotio mrhotio reopened this Jul 17, 2022
@mrhotio mrhotio added question Further information is requested and removed update Logo updates or additions to *.index labels Jul 17, 2022
@Lexzie
Copy link
Member

Lexzie commented Jul 18, 2022

I have created one, I will post a link in piconcreators soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Development

No branches or pull requests

4 participants