-
-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a docker container for development, or at least update doc #876
Comments
@kindlydodo I've updated my PR #863 with Docker dev env setup. Please try. Is it what you need? |
Looks awesome, thank you! |
@kindlydodo Mapping the source code inside the container is easy by adding a new volume to the Photoview service in the docker-compose. However, now it is pretty useless, as you anyway need to recompile the code and reload it on the web server. Right now the code compilation and web server building are done in the same way, as for the production image (at the time of building the image). To let you see the result of modifying the code on the fly, the development container should run the development web server. For the frontend code, the nodeamon or webpack can be used. For the Golang Realize or Air could be used. I'm not a developer, so I don't know how exactly to configure these servers to work with this project. The additional challenge might be to make them work together, as now everything is served by the same server, while in this development setup, there should be separate processes (ideally different containers) for the frontend and backend. So, if you can configure that and make it work, provide me the detailed guide to replicate that in the PR or step in and commit there your working config. |
If you only want to modify the front end, maybe using a reverse proxy server can be a choice.
|
We might need to review this issue after #863 is merged to provide a consistent environment. Also, a help from a frontend and backend developer will be needed to correctly configure the |
Is your feature request related to a problem? Please describe.
I try to dig into this project. The very first thing I need is an environment. What I have found is:
https://photoview.github.io/en/docs/installation-manual/
To keep my system clean, I would appreciate to use a docker container for development.
Describe the solution you'd like
Provide a dockerfile, or image with an setup development environment for photoview, or at least update the documentation
I’m trying to set up this but I am failing.
Thank you
The text was updated successfully, but these errors were encountered: