-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dependency in Plugin application #28
Comments
From #19:
Your plugins system uses .zip or .jar format to pack your plugins? |
Refer plugin pom.xml file, yes i have created thin jar file for testing. For testing I have used Simple-Json as third pary lib. Yes my plugin system as .jar format |
Probably your plugins packaging approach is based on |
Yes, I am referring pf4j-spring. Will you able to tell me what is the mistake in the existing plugin project. When I use plugin application as ZIP file, its working fine. Help me on JAR |
I didn't say that something is wrong with |
I was going to enter an issue or try to ask a question that seems related to the above, so I'll ask it here for now: Can you elaborate on if we should be using .zip or .jar plugin files? The pf4j-spring demo builds .zip files, but the run-demo.sh script doesn't use them...it copies the .jar files instead. When I try copying the .zip files instead, the app fails to find the plugin class implementation. I notice that the .zip files do have additional dependencies in them, so maybe in general they are needed. I think maybe what you're saying is that the main pf4j demo shows the way to build plugins as .jar files that include the dependencies. Is that right? Could you possibly update the pf4j-spring demo to demonstrate the most correct way to do things? If not, maybe you could provide some information in a more obvious place regarding just how to best get going with your project if your demo isn't the best way. |
I believe I've done what I asked to have the author do above. I've submitted a pull request for this work. |
I have executed the run-demo.bat file and successfully executed. Please guide me on how do I check the demo project. |
I fixed the run-demo scripts. Please run-demo again.
|
Not able to build plugin1 and 2 projects “mvn clear package” |
@MohankumarD |
@decebals |
@MohankumarD <dependency>
<groupId>commons-lang</groupId>
<artifactId>commons-lang</artifactId>
<version>2.6</version>
</dependency> You can add what dependencies you want. At the end, to create the new plugin distribution (plugin.zip) you must:
The plugin file ( |
I am trying to build app and plugin separately but I can't. for demo separately its ok to build in one short.
|
@MohankumarD |
Yes, I can. But I am not build plugin project alone. I want to build APP and PLUGIN seprately and deploy plugin as JAR file. |
Now, I think that I understood what you say.
|
Now, I have added a new dependency in Plugin2. Yes, a ZIP file is working, but still, like a JAR file, I am getting same issue (I am not able to pack plugin as a JAR for deployment). |
For a demo with plugins in format JAR please see PF4J demo. |
Hi Decebals,
I am facing the same issue, can you please help on this how to add a dependency for third-party jar..
Also added dependency in
assambly.xml
file:Originally posted by @MohankumarD in #19 (comment)
The text was updated successfully, but these errors were encountered: