Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ideas for next major update #88

Open
paulmillr opened this issue May 15, 2024 · 3 comments
Open

Ideas for next major update #88

paulmillr opened this issue May 15, 2024 · 3 comments

Comments

@paulmillr
Copy link
Owner

paulmillr commented May 15, 2024

  • Remove cryptoNode import! Requires to ditch support for nodejs v18 (EOL 30 Apr 2025)
  • Remove import maps. Change @noble/hashes/sha3 to @noble/hashes/sha3.js
    • Import maps are not browser-friendly etc
    • Before doing this, actually test in real browser
  • Test in different environments:
    • bundler-less browser
    • deno
    • bun
  • See how package can fit for JSR.io
  • Rename / refactor
    • crypto / cryptoNode => webcrypto (to match noble-ciphers)
    • sha256, sha512 => sha2? not sure yet
    • blake2b, blake2s, blake3 => blake?
    • ripemd160 => ripemd?
    • sha1 => legacy? and add md5??

Maybe also:

  • Make package ESM-only
  • Re-audit (need $ funds)
@imcotton
Copy link

imcotton commented Jun 5, 2024

Any thoughts on adding non-cryptographic hashes? e.g.:

  • CRC32
  • Murmur3
  • xxHash
  • City
  • etc...

@paulmillr
Copy link
Owner Author

What would be the use case?

@imcotton
Copy link

imcotton commented Jun 5, 2024

In general non-cryptographic hashes give synchronize call which widely applicable.

CRC32 is good for quick integrity check.

Both Murmur3 and xxHash commonly used in Bloom Filter, however existing widely used NPM packages all using old syntax (ES5, CJS) and have no updates in 5-6 years.

In case of Murmur3, rarely handle utf8 correctly1. Jumping rabbit hole forks lead to inactive non-resolved issue2

Footnotes

  1. https://github.com/cimi/murmurhash3js-revisited

  2. https://github.com/karanlyons/murmurHash3.js/issues/13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants