Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): avoid infinite loop when traverse ancestors in jest/no_conditional_expect #3330

Conversation

mysteryven
Copy link
Member

closes: #3325

Copy link

graphite-app bot commented May 17, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-linter Area - Linter label May 17, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @mysteryven and the rest of your teammates on Graphite Graphite

Copy link

codspeed-hq bot commented May 17, 2024

CodSpeed Performance Report

Merging #3330 will not alter performance

Comparing 05-17-fix_linter_avoid_infinite_loop_when_traverse_ancestors_in_jest/no_conditional_expect_ (385965f) with main (e241136)

Summary

✅ 27 untouched benchmarks

@mysteryven mysteryven force-pushed the 05-17-fix_linter_avoid_infinite_loop_when_traverse_ancestors_in_jest/no_conditional_expect_ branch from af67b27 to 12a9910 Compare May 17, 2024 14:07
@Boshen Boshen added the merge label May 17, 2024
Copy link

graphite-app bot commented May 17, 2024

Merge activity

  • May 17, 10:11 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • May 17, 10:11 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • May 17, 10:19 AM EDT: Boshen merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the 05-17-fix_linter_avoid_infinite_loop_when_traverse_ancestors_in_jest/no_conditional_expect_ branch from 12a9910 to 385965f Compare May 17, 2024 14:12
@graphite-app graphite-app bot merged commit 385965f into main May 17, 2024
28 checks passed
@graphite-app graphite-app bot deleted the 05-17-fix_linter_avoid_infinite_loop_when_traverse_ancestors_in_jest/no_conditional_expect_ branch May 17, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

linter: panic in jest/no_conditional_expect
2 participants