Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): backward compability for react-hooks and deepscan plugins #3334

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented May 17, 2024

closes #3317

Copy link

graphite-app bot commented May 17, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-linter Area - Linter label May 17, 2024
Copy link
Member Author

Boshen commented May 17, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Boshen and the rest of your teammates on Graphite Graphite

@Boshen Boshen added the merge label May 17, 2024
Copy link

codspeed-hq bot commented May 17, 2024

CodSpeed Performance Report

Merging #3334 will degrade performances by 3.91%

Comparing 05-17-feat_linter_backward_compability_for_react-hooks_and_deepscan_plugins (e4b3a3c) with main (a23bbf9)

Summary

❌ 1 regressions
✅ 26 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main 05-17-feat_linter_backward_compability_for_react-hooks_and_deepscan_plugins Change
semantic[pdf.mjs] 136.2 ms 141.7 ms -3.91%

@Boshen Boshen force-pushed the 05-17-feat_linter_backward_compability_for_react-hooks_and_deepscan_plugins branch from 0a10a20 to 3cf5f55 Compare May 17, 2024 16:04
Copy link

graphite-app bot commented May 17, 2024

Merge activity

@Boshen Boshen force-pushed the 05-17-feat_linter_backward_compability_for_react-hooks_and_deepscan_plugins branch from 3cf5f55 to e4b3a3c Compare May 17, 2024 16:09
@graphite-app graphite-app bot merged commit e4b3a3c into main May 17, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 05-17-feat_linter_backward_compability_for_react-hooks_and_deepscan_plugins branch May 17, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

linter: map rules of hooks to react-hooks
1 participant