Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exported bookmark lists with accented characters get renamed to generic names #8201

Open
nonobio opened this issue May 17, 2024 · 7 comments
Labels
Bookmarks and Tracks Bookmarks, imported tracks, and KML, KMZ, KMB, GPX import or export Bug Something isn't working

Comments

@nonobio
Copy link

nonobio commented May 17, 2024

Describe the issue
When exporting multiple bookmark lists at once using the Organic Maps Android app, lists with names containing accented characters (such as é, è, ê, ù, â etc.) are replaced by generic names like OrganicMaps_1, OrganicMaps_2, etc.

Steps to reproduce

  1. Open the Organic Maps app on an Android device

  2. Create multiple bookmark lists with names containing accented characters (e.g., "Cafés", "Rivières", "Forêts, Où manger, Châteaux")
    image
    If necessary, here is a kmz with lists with accents: OrganicMapsBackup_List names with accents.zip

  3. Export all bookmark lists at once
    image

  4. Open kmz file with 7zip (or another zip tool) or in Google Earth (Windows, Web or Android)
    List names with accents are not preserved and replaced by OrganicMaps_1, OrganicMaps_2, etc.
    Example in 7-zip:
    image
    Example in Google Earth Windows:
    image
    Example in Google Earth Web:
    image
    Example in Google Earth Android:
    image

Expected behaviour
The exported bookmark lists should retain their original names, including any accented characters.

System information:

  • Operating system and its version: [Android 10]
  • Organic Maps version: [2024.03.31-8-Google]
  • Device Model: [Motorola Moto G7 Plus]

Additional context
Thanks for this great function, I hadn't noticed it and I was exporting my bookmark lists one by one.

Until this bug is eventually resolved, I am careful that there are no accents in the names of my lists, like this:
image
If necessary, here is a kmz with lists of names without accents: OrganicMapsBackup_List names without accents.zip

so that when opening it I have the correct list names:
Example in 7-zip:
image

Example in Google Earth Windows:
image

Apparently, there is no problem with the accents of bookmark names (inside lists).

Thanks :)

@biodranik
Copy link
Member

The main issue is that using non-ASCII characters in file names inside a .zip file may not work properly on all platforms. Did anyone make a research about the current state of this issue? What is the most reliable way to generate compatible .kmz files? (it's a kml inside a .zip)

@nonobio
Copy link
Author

nonobio commented May 17, 2024

Thank you for your answer. In the meantime I saw that I had to make a duplicate of #7453

@krozhdestvenski
Copy link
Contributor

can't reproduce
image

System information:
Operating system and its version: [Android 14]
Organic Maps version: [2024.05.09-1-FDroid-debug]
Device Model: [Google Pixel 7 API 34 (emulated)]

@biodranik
Copy link
Member

@nonobio please share any kmz that are not open in OM, we need to fix it. Google Earth is a good tool, you may also try https://umap.openstreetmap.fr/

@nonobio nonobio changed the title Exported bookmark lists with accented characters get renamed to generic names Exported bookmark lists with accented characters get renamed to generic names when opened in Google Earth Windows May 20, 2024
@nonobio nonobio changed the title Exported bookmark lists with accented characters get renamed to generic names when opened in Google Earth Windows Exported bookmark lists with accented characters get renamed to generic names when opened in Google Earth Windows or Web May 20, 2024
@nonobio nonobio changed the title Exported bookmark lists with accented characters get renamed to generic names when opened in Google Earth Windows or Web Exported bookmark lists with accented characters get renamed to generic names when opened in Google Earth May 20, 2024
@nonobio
Copy link
Author

nonobio commented May 20, 2024

can't reproduce
System information: Operating system and its version: [Android 14] Organic Maps version: [2024.05.09-1-FDroid-debug] Device Model: [Google Pixel 7 API 34 (emulated)]

@krozhdestvenski Weird. Is it Google Earth that you used? I don't recognize it.
I edited my first post to provide more details and I also attached kmz files to test.

@nonobio please share any kmz that are not open in OM, we need to fix it. Google Earth is a good tool, you may also try https://umap.openstreetmap.fr/

Here is an example of a kmz file that does not open in OrganicMaps:
Organic Maps Bookmarks and Tracks_Saved from Google Earth.zip (It is just an OrganiMapsBackup.kmz file opened in Google Earth then saved from Google Earth as kmz file).

But, I don't know if this is a bug or just normal behavior:

  • I open a kmz file exported from the Export all lists function of Organic Maps (see example of files in my first post)
  • I open the file in Google Earth (Windows)
  • I save the file from Google Earth az kmz file:
    image
  • I then try to open this new kmz file in Organic Maps but it doesn't work:
    image

You will tell me, but why do that? ;) Actually, I thought I could edit this OrganicMapsBackup.kmz file in Google Earth. I just renamed a list, and I wanted to save my modification like this. But I notice that the kmz file is very small and that it only contains (by opening it in zip with 7zip) the doc.kml file (there is no longer the files folder containing the kml lists).
Afterward, I realize that I can't really modify this kmz in Google Earth: for example, I can't add places to my lists.
This is why I start by unzipping the kmz before opening it in Google Earth to make modifications, as I explain here. This seems to be the way to use but tell me again if there is a way to edit this kmz in Google Earth directly...

Google Earth is a good tool, you may also try https://umap.openstreetmap.fr/

Thank you, I tried to import my OrganicMapsBackup.kmz file.
First umap tells me "Unable to detect the format..."
I choose the kml format, I then see my file name in the layers but I can't expand the contents of my OrganicMapsBackup.kmz image

Then I tried with a kml file, it opens and I can develop its content.
But all the icons are the same:
image

but I was not very successful in finding the functions that I use in Google Earth Window, at least for this use of kml kmz management.

@biodranik
Copy link
Member

biodranik commented May 20, 2024

The kmz file that is not opening contains only references to your other local files, which are obviously absent in the kmz archive:

<?xml version="1.0" encoding="UTF-8"?>
<kml xmlns="http://www.opengis.net/kml/2.2" xmlns:gx="http://www.google.com/kml/ext/2.2" xmlns:kml="http://www.opengis.net/kml/2.2" xmlns:atom="http://www.w3.org/2005/Atom">
<Document>
    <name>Organic Maps Bookmarks and Tracks</name>
    <open>1</open>
    <NetworkLink>
        <name>Chateaux</name>
        <Link>
            <href>OrganicMapsBackup_List names without accents.kmz/files/Chateaux.kml</href>
        </Link>
    </NetworkLink>
    <NetworkLink>
        <name>Ou manger</name>
        <Link>
            <href>OrganicMapsBackup_List names without accents.kmz/files/Ou manger.kml</href>
        </Link>
    </NetworkLink>
    <NetworkLink>
        <name>Forets</name>
        <Link>
            <href>OrganicMapsBackup_List names without accents.kmz/files/Forets.kml</href>
        </Link>
    </NetworkLink>
    <NetworkLink>
        <name>Cafes</name>
        <Link>
            <href>OrganicMapsBackup_List names without accents.kmz/files/Cafes.kml</href>
        </Link>
    </NetworkLink>
    <NetworkLink>
        <name>Rivieres</name>
        <Link>
            <href>OrganicMapsBackup_List names without accents.kmz/files/Rivieres.kml</href>
        </Link>
    </NetworkLink>
</Document>
</kml>

@nonobio
Copy link
Author

nonobio commented May 20, 2024

Yes indeed, there is no longer the files folder and the kml inside the kmz, so it must be Google Earth which is not recording everything correctly. It only seems to save the root element that I right-click on to "save"...
I don't know if this is normal behavior or a bug.

@nonobio nonobio changed the title Exported bookmark lists with accented characters get renamed to generic names when opened in Google Earth Exported bookmark lists with accented characters get renamed to generic names May 20, 2024
@patepelo patepelo added Bug Something isn't working Bookmarks and Tracks Bookmarks, imported tracks, and KML, KMZ, KMB, GPX import or export labels May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bookmarks and Tracks Bookmarks, imported tracks, and KML, KMZ, KMB, GPX import or export Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants