Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Change rollout CustomResourceDefinition configuration conversionReviewVersions to v1 #1558

Open
zmberg opened this issue Apr 2, 2024 · 3 comments
Assignees

Comments

@zmberg
Copy link
Member

zmberg commented Apr 2, 2024

What would you like to be added:
ConversionReview v1beta1 deprecated in v1.16 in favor of apiextensions.k8s.io/v1, refer to: https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definition-versioning/#webhook-request-and-response

  1. Change rollout CustomResourceDefinition configuration conversionReviewVersions to v1, related code: https://github.com/openkruise/rollouts/blob/master/config/crd/patches/webhook_in_batchreleases.yaml and https://github.com/openkruise/rollouts/blob/master/config/crd/patches/webhook_in_rollouts.yaml
  2. webhook controller, related code: https://github.com/openkruise/rollouts/blob/master/pkg/webhook/util/crd/crd.go#L79

Why is this needed:

@im-jinxinwang
Copy link

@zmberg
I understand that it is enough to remove v1beta1?

newCRD.Spec.Conversion.Webhook = &apiextensionsv1.WebhookConversion{
    ClientConfig:             webhookConfig.DeepCopy(),
    ConversionReviewVersions: []string{"v1"},
}

@chenshiwei-io
Copy link

Is it just changing 'v1beta1' to 'v1' in the configuration of these two CRDs, and then deleting 'v1beta1' from the code? I want to try submitting the feature request."
/assign

@chenshiwei-io
Copy link

@zmberg This feature belongs to #rollouts, Is the rollouts PR I submitted associated with this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants