Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Support a SidecarSet canary on a newly created pod with version control for injection and selector #1539

Open
amirakhmedov opened this issue Mar 22, 2024 · 0 comments

Comments

@amirakhmedov
Copy link

What would you like to be added:
Add support for a SidecarSet canary on a newly created pod with a canary labels set using version control for injection and selector.

Why is this needed:
I want to use the combination of the two to canary a new version of a sidecar on pods with a canary label attached. This will guarantee that newly created pods will get injected a stable version of the sidecar. It works fine if only in-place update is possible. But if in-place update is impossible, let's say a canary version requires a new env variable to be added, then a newly created pod with a canary label set on it still gets injected a stable version of the sidecar.
I would like to see a mutating webhook to take into consideration .spec.updateStrategy.selector to make a decision which version of a SidecarSet (stable or canary) to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants