Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add builder mode when editing a modelfile #187

Closed
jeremiahsb opened this issue Dec 6, 2023 · 4 comments
Closed

feat: add builder mode when editing a modelfile #187

jeremiahsb opened this issue Dec 6, 2023 · 4 comments
Assignees
Milestone

Comments

@jeremiahsb
Copy link

I know that the modelfile support is still in development, so not sure if this is a bug or a feature request. When you go into the modelfiles section and create a new modelfile, you have the option to toggle between builder mode and raw format. If you've previously created a modelfile and go back in to edit it, you don't see the option for builder mode, raw format is selected by default.

It would be nice to have the edit functionality behave like the create functionality. Not a deal breaker by any stretch, just a small quality of life improvement.

@tjbck
Copy link
Contributor

tjbck commented Dec 7, 2023

Hi, It indeed is WIP at the moment, will add the builder mode to edit page as well in the near future. Stay tuned, Thanks!

@silentoplayz
Copy link
Collaborator

silentoplayz commented Apr 13, 2024

I'm bumping this issue as it hasn't had any activity since Dec 2023. This issue is still valid for the most part, as the Modelfile Format option is unavailable/missing from the UI when going back to edit a previously created Modelfile. The Builder Mode is selected by default now, unlike what was mentioned before:

"you don't see the option for builder mode, raw format is selected by default."

From my findings, this also prevents modifications to advanced model parameters (directly from the Modelfile itself) with an already created Modelfile too. That is because Modelfile Advanced Settings is only available in Raw Format mode. This isn't the main issue I'd like to point out, as yes, advanced model parameters are indeed "advanced" settings. With this being said, I am pointing out why it could still be seen as an issue that the option for switching models in an already made Modelfile is missing.

@tjbck
Copy link
Contributor

tjbck commented Apr 14, 2024

PR for #665 should include this feature as well.

@tjbck tjbck added this to the v0.2.0 milestone May 26, 2024
@tjbck tjbck self-assigned this May 26, 2024
@tjbck
Copy link
Contributor

tjbck commented May 26, 2024

Added to our dev branch!

@tjbck tjbck closed this as completed May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants