Add option to turn off CopyWebpackPlugin minification for asset

[flippidippi]

• I'd be willing to implement this feature (contributing guide)

Description

Allow an additional option to be passed to the CopyWebpackPlugin for assets to prevent minification.

Motivation

Currently we use the assets feature of nx to copy files from app builds into deploy projects that are already minified.
Unfortunately there is currently no way to pass the info: { minimized: true }, option to the CopyWebpackPlugin.
This results in JS files being re-minified, or minified when they shouldn't be (because the build project has optimization off).

Another use case we have is JS that we are sent as an asset and need the copy plugin to leave the JS alone during the copy.

Suggested Implementation

Add an additional option to the assets object in project.json to send minimized: true, that will then be passed to the CopyWebpackPlugin for that asset.

        "assets": [
          "apps/test-deploy/src/assets",
          {
            "input": "apps/test-deploy",
            "glob": "cdk.json",
            "output": "."
          },
          {
            "input": "dist/apps/test",
            "glob": "main.js",
            "output": "assets",
            "minimized": true
          }
        ],

See

nx/packages/webpack/src/utils/config.ts

Line 327 in 60a7345

export function createCopyPlugin(assets: AssetGlobPattern[]) {

Alternate Implementations

We could also send exclude options to the TerserWebpackPlugin, but I think signaling the assets in the copy plugin is easier and more maintainable.

[danr-za]

The best take over webpack customization would be eventually to export the building blocks of it (ts, react, styles, modification) as functions and expose a webpack configuration for every generated project.
This is because supporting every property of webpack in project.json would be a killer.

This way, we could customize it entirely to our demands.
Btw, this is something already done in vite (in some way).

I'll open a feature request for that.

[github-actions[bot]]

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs.
If we missed this issue please reply to keep it active.
Thanks for being a part of the Nx community! 🙏

[flippidippi]

Any updates on this @danr-za? Did we get a feature request for this?

[jaysoo]

The workaround for now would be to set optimization: false and add in Terser plugin manually in your webpack config.

I think we could add terserOptions as a way to pass options directly to the Terser plugin, so you can add exclude amongst other things.

[flippidippi]

Yeah that exclude I think would also work and would be flexible