Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update_maps shard_size is deprecated #203

Open
rguo123 opened this issue Aug 8, 2023 · 0 comments
Open

update_maps shard_size is deprecated #203

rguo123 opened this issue Aug 8, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@rguo123
Copy link
Collaborator

rguo123 commented Aug 8, 2023

update_maps currently passes a shard_size parameter. Within the method, update_maps creates a progress bar based on shard_size and assumes it is a numeric value. However, when this value then gets passed to add_embeddings or add_text, shard_size is treated as deprecated and will raise a warning.

Hence, due to this conflict, the method does not work. The task to fix this is to remove shard_size option from update_maps.

@rguo123 rguo123 added the bug Something isn't working label Aug 8, 2023
@rguo123 rguo123 self-assigned this Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant