Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise more informative better errors, change some warnings to errors. #144

Open
bmschmidt opened this issue Apr 25, 2023 · 3 comments
Open

Comments

@bmschmidt
Copy link
Collaborator

User feedback.

I feel you should raise an error instead of only logging something if I’ve run out of storage. In prod I need to abort if I’ve hit the limit or I might end up serving a db with only half the points in. This also happens if I try to upload values which have conflicting ids. At the very least don’t log ‘Upload succeeded’ when it didn't

@bmschmidt bmschmidt changed the title Formalize error policy Raise more informative better errors, change some warnings to errors. May 30, 2023
@bmschmidt
Copy link
Collaborator Author

Our details on failed uploads can be extremely uninformative, and should be improved. Example from discord

Shard upload failed: {"detail":"Upload failed"}
Additional info: {"detail":"Your project has only 0 datums. Please add at least 20 datums!"}

@ez2rok
Copy link

ez2rok commented Jun 6, 2023

I received the same error
Additional info: {"detail":"Your project has only 0 datums. Please add at least 20 datums!"}
when accidentally including nan values in my data. We should raise a separate error if the data contains a nan value.

@iblind
Copy link

iblind commented Aug 4, 2023

I've also encountered the same error as @ez2rok did (re: 20 datums) but the data I'm uploading contains several thousand data points. I'm not sure how this behavior emerges/where the error actually is, but I don't have any nan values in my dataset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants