Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger: Handle multiple ACIR calls #4824

Open
vezenovm opened this issue Apr 16, 2024 · 1 comment · May be fixed by #5051
Open

Debugger: Handle multiple ACIR calls #4824

vezenovm opened this issue Apr 16, 2024 · 1 comment · May be fixed by #5051
Labels
debugger enhancement New feature or request

Comments

@vezenovm
Copy link
Contributor

vezenovm commented Apr 16, 2024

Problem

With the introduction of #4428 we now support multiple ACIR function calls. Inlining remains the default, however, functions marked with #[fold] (or potentially other inline markers in the future) will be treated as separate ACIR functions. Execution has been updated in the ACVM and nargo to handle these new non-inlined methods but not in the debugger.

The relevant work that updated the codegen and execution for non-inlined ACIR can be found linked in the main issue linked above.

cc @ggiraldez @mverzilli

Happy Case

It would be nice to be able to use the debugger even when executing non-inlined ACIR. This will be especially useful as we potentially add more inline markers such as #[inline(never)].

Project Impact

Nice-to-have

Impact Context

No response

Workaround

None

Workaround Description

No response

Additional Context

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@vezenovm vezenovm added enhancement New feature or request debugger labels Apr 16, 2024
@mverzilli
Copy link
Contributor

Hi @vezenovm! We're looking into this

@ggiraldez ggiraldez linked a pull request May 17, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debugger enhancement New feature or request
Projects
Status: 📋 Backlog
Development

Successfully merging a pull request may close this issue.

2 participants