Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timezones in Country table for Country AU are for Daylight savings time, not standard. #85

Closed
TheITJuggler opened this issue May 15, 2024 · 2 comments

Comments

@TheITJuggler
Copy link

Describe the bug
For the Australian states that follow daylight savings time, the UTC offset and the Time zone name reflect only the Dayligh Savings zone details.

To Reproduce
Go to World/resources/json/countries.json
Find zonename Australia/Sydney
See that GMTOffset and GMTOffsetName are off by an hour
See that TZName contains "Daylight" and not "Standard"

Expected behavior
Additional column indicating if timezone follows daylight savings
Additional column indicating daylight savings incremement (default 3600)
Additional column indicating daylight savings TZname (i.e AEST becomes AEDT in daylight savings)
Possibly include tzdata

Desktop (please complete the following information):
N/A

Smartphone (please complete the following information):
N/a

Additional context
Add any other context about the problem here.

@nnjeim
Copy link
Owner

nnjeim commented May 15, 2024

@TheITJuggler Thank you for your input, if i remember right the timezones in the countries.json were used only to seed the table timezones. Multiple timezones should be available for Australia.
The purpose of this is to allow a user to select his current timezone but no timezone translation is offered by the package.
Check the table timezones pls and let me know if more information could be added there.

@nnjeim
Copy link
Owner

nnjeim commented May 24, 2024

closed by lack of input

@nnjeim nnjeim closed this as completed May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants