Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump msw to new API #2040

Open
3 tasks
szilarddoro opened this issue Jun 14, 2023 · 5 comments · May be fixed by #2090
Open
3 tasks

Bump msw to new API #2040

szilarddoro opened this issue Jun 14, 2023 · 5 comments · May be fixed by #2090
Assignees
@onehassan
Labels
enhancement New feature or request

Comments

@szilarddoro
Copy link
Contributor

szilarddoro commented Jun 14, 2023 •
edited

MSW doesn't support Node.js v18 yet so the tests are still running on Node.js v16. Bump the version in the CI once MSW adds Node.js v18 support.

Please refer to this issue:
mswjs/msw#1388

Tasks
Beta Give feedback
@szilarddoro szilarddoro added the enhancement New feature or request label Jun 14, 2023
@szilarddoro szilarddoro changed the title bump Node.js to v18 Bump Node.js to v18 Jun 14, 2023
@dbarrosop
Copy link
Contributor

Does it makes sense to use next as this comment describes? mswjs/msw#1388 (comment)

@szilarddoro
Copy link
Contributor Author

We can give it a shot, yes.

@szilarddoro
Copy link
Contributor Author

I tried it but the tests will break after upgrading to msw@next so I'd say let's wait for a proper release or a better release candidate.

@onehassan
Copy link
Contributor

onehassan commented Jul 3, 2023 •
edited

It seems that there are breaking changes to how we write tests

https://github.com/mswjs/msw/blob/feat/standard-api/MIGRATING.md

Currently migrating to use the new API

@onehassan onehassan linked a pull request Jul 4, 2023 that will close this issue
Draft
@dbarrosop dbarrosop changed the title Bump Node.js to v18 Bump msw to new API Jul 27, 2023
@stale Stale
Copy link

stale bot commented Jan 23, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 23, 2024
@dbarrosop dbarrosop removed the stale label Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onehassan onehassan

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: upgrade msw nhost/nhost
3 participants
@szilarddoro @onehassan @dbarrosop