Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint checks for ViewProvidingScene #92

Open
nhaarman opened this issue Nov 25, 2018 · 0 comments
Open

Lint checks for ViewProvidingScene #92

nhaarman opened this issue Nov 25, 2018 · 0 comments
Labels
priority:medium This issue has a medium priority type:feature New feature

Comments

@nhaarman
Copy link
Owner

nhaarman commented Nov 25, 2018

See #91 (comment):

This could use a lint check: createViewController returns a ViewController instance, but a compile time check for V is not possible, see https://stackoverflow.com/questions/43790137/why-cant-type-parameter-in-kotlin-have-any-other-bounds-if-its-bounded-by-anot

The lint check could check Scenes implementing ViewControllerFactory and check whether the return type of createViewController also adheres to the Scene's Container type.

Also, a Lint check checking whether ViewProvidingScene is only used with Scenes can be created (#91 (comment)).

@nhaarman nhaarman added type:feature New feature priority:medium This issue has a medium priority labels Nov 25, 2018
@nhaarman nhaarman changed the title Lint check for ViewProvidingScene Lint checks for ViewProvidingScene Nov 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:medium This issue has a medium priority type:feature New feature
Projects
None yet
Development

No branches or pull requests

1 participant