Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: passive wheel event listener in virtualized list #2667

Conversation

tienifr
Copy link
Contributor

@tienifr tienifr commented May 14, 2024

Details

Fixes #2658

We used custom logic for wheel event in VirtualizedList thus enabling passive event is not possible.

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1e610ad:

Sandbox Source
react-native-web-examples Configuration

@tienifr
Copy link
Contributor Author

tienifr commented May 14, 2024

@necolas Hi, could you please prioritize merging this because my earlier PR #2601 had caused a critical issue that broke the scrolling function in VirtualizedList. Sorry for the inconvenience.

@necolas necolas closed this in 2098b1f May 17, 2024
@bernhardoj

This comment was marked as off-topic.

@xavigonz

This comment was marked as off-topic.

@necolas
Copy link
Owner

necolas commented May 22, 2024

Please don't pester me about releases

Repository owner locked as resolved and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants