Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reports fs.exists() to be blocking with Node V8.x #17

Open
gjegadesh opened this issue Jul 3, 2018 · 2 comments
Open

Reports fs.exists() to be blocking with Node V8.x #17

gjegadesh opened this issue Jul 3, 2018 · 2 comments

Comments

@gjegadesh
Copy link

gjegadesh commented Jul 3, 2018

I am surprised to see that fs.exists() blocks. Please clarify. Thanks

blocked-at V1.1.2
Node JS V8.9.4

[2018/07/03 11:25:45.933] [INFO] { blockedFor: 1054.224799987793,
stack:
[ ' at Object.fs.exists (fs.js:310:11)',
' at getXYZ (C:\dev\prj1\routes\XYZ.js:122:10)',
' at h.XYZ (C:\dev\prj1\routes\XYZ.js:69:37)',
' at Layer.handle [as handle_request] (C:\dev\prj1\node_modules\express\lib\router\layer.js:95:5)',
' at trim_prefix (C:\dev\prj1\node_modules\express\lib\router\index.js:312:13)',
' at C:\dev\prj1\node_modules\express\lib\router\index.js:280:7',
' at Function.process_params (C:\dev\prj1\node_modules\express\lib\router\index.js:330:12)',
' at next (C:\dev\prj1\node_modules\express\lib\router\index.js:271:10)',
' at SendStream.error (C:\dev\prj1\node_modules\serve-static\index.js:121:7)',
' at emitOne (events.js:116:13)',
' at SendStream.emit (events.js:211:7)',
' at SendStream.error (C:\dev\prj1\node_modules\send\index.js:275:17)',
' at SendStream.onStatError (C:\dev\prj1\node_modules\send\index.js:392:12)',
' at onstat (C:\dev\prj1\node_modules\send\index.js:674:26)',
' at FSReqWrap.oncomplete (fs.js:152:21)' ] }

@naugtur
Copy link
Owner

naugtur commented Aug 23, 2018

It doesn't block, so this is a false positive.
Would you be so kind to try and add a PR with a testcase for this?

@yyfearth
Copy link

I think it has false positive on async and await.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants