Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mobile Support] Clicking navigation objects should automatically close the tree pane #7313

Open
3 of 7 tasks
rukmini-bose opened this issue Dec 19, 2023 · 4 comments · May be fixed by #7553
Open
3 of 7 tasks

[Mobile Support] Clicking navigation objects should automatically close the tree pane #7313

rukmini-bose opened this issue Dec 19, 2023 · 4 comments · May be fixed by #7553
Labels
bug:regression It used to work. Now it doesn't :( severity:trivial type:bug
Projects
Mobile Support

Comments

@rukmini-bose
Copy link
Contributor

rukmini-bose commented Dec 19, 2023 •
edited

Summary

Open MCT needs to have a more responsive UX when it comes to its mobile design.
There are two main issues:

  1. When a user is navigating the tree and clicks on an object from the tree (this includes Recent Objects), we would want the tree pane to close automatically after. This allows for more space to view the elements in the main frame. Currently, after the user selects an object from the tree, they have to manually select the hamburger menu located at the top right of the screen in order to hide the tree and show the main frame. It is important to note that this is a regression.

  2. For the new global search that is in mobile, when a user clicks on one of the objects from the search results, we want the search overlay to close, as well as the tree pane to collapse (if it was already open before the search started).

Expected vs Current Behavior

After selecting an item from the tree, the tree pane should automatically close.

Steps to Reproduce

  1. Go to Open MCT in mobile– either using the devtools, or on your mobile device. If you are using devtools, be sure to empty cache and hard reload
  2. Go to the object tree, by clicking the hamburger menu in the top left corner.
  3. Select an object from the tree.
  4. Observe that once selected, you have to manually close the tree pane by clicking the hamburger menu, in order to view the object in the main frame.

SEARCH ISSUE:

  1. Go to Open MCT in mobile.
  2. Make sure the tree is expanded.
  3. Use the global search function to being a search querey.
  4. Click on one of the search results.
  5. Observe that while the search results popup closes, you are still seeing the Object Tree.
  6. Observe that you have to click on the hamburger menu button to collapse the tree to see the object you selected from search.

Environment

  • Open MCT Version: 3.3.0
  • Deployment Type: /testathon (but this is reproducable anywhere)
  • OS:
  • Browser: Chrome

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information
@rukmini-bose rukmini-bose added this to To do in Mobile Support via automation Dec 19, 2023
@rukmini-bose rukmini-bose changed the title [Mobile] Clicking tree should automatically close the pane [Mobile Support] Clicking tree should automatically close the pane Dec 19, 2023
@rukmini-bose rukmini-bose added the bug:regression It used to work. Now it doesn't :( label Dec 19, 2023
@unlikelyzero
Copy link
Collaborator

@rukmini-bose when did this last work?

@charlesh88
Copy link
Contributor

@unlikelyzero I believe this used to work in 1869. After the introduction of internal combustion, it regressed. Suffice to say, it's been a while.

@charlesh88
Copy link
Contributor

Also: this fix should also do the same thing when a search is clicked, as in #7349.

@rukmini-bose rukmini-bose changed the title [Mobile Support] Clicking tree should automatically close the pane [Mobile Support] Clicking navigation objects should automatically close the tree pane Feb 28, 2024
@rukmini-bose rukmini-bose linked a pull request Mar 5, 2024 that will close this issue
Open
15 tasks
@rukmini-bose
Copy link
Contributor Author

rukmini-bose commented Mar 20, 2024 •
edited by charlesh88

Testing Instructions:

  1. Go to Open MCT on mobile and select a phone portrait device.
  2. Make sure that the Object Tree is expanded.
  3. Click on an item from the Object Tree and verify that the tree pane closes, and navigates you to the selected object.
  4. Expand the tree again and if recent items is visible, click an item from there and verify that the tree pane closes and navigates you to the select object. This step is optional, since there is a current bug in which the object tree and recent items is broken and sometimes does not appear. This issue will be resolved in a different PR.
  5. Once again, expand the tree pane. Now to go Search. Execute a search query, and select one of the options from the results. Verify that upon selecting a search result, the search closes, as well as the tree pane, and navigates you to the selected result.
  6. Now change the mobile orientation to landscape
  7. Repeat steps 2 and 3, but verify that the tree pane does not close. Instead, it should stay open while navigating you to the selected object.
  8. Repeat step 5, but verify that clicking on a search result merely closes the search, keeps the tree pane open, and navigates you to the selected object.

@rukmini-bose rukmini-bose mentioned this issue Mar 21, 2024
Open
@rukmini-bose rukmini-bose moved this from To do to In progress in Mobile Support Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug:regression It used to work. Now it doesn't :( severity:trivial type:bug
Projects
Mobile Support
In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Mobile] Allow automatic closing of panes when nav object is clicked nasa/openmct
4 participants
@charlesh88 @jvigliotta @unlikelyzero @rukmini-bose