Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAI Assistant creating new thread everytime #9399

Closed
yuri12344 opened this issue May 14, 2024 · 8 comments
Closed

OpenAI Assistant creating new thread everytime #9399

yuri12344 opened this issue May 14, 2024 · 8 comments
Labels
in linear Issue or PR has been created in Linear for internal review

Comments

@yuri12344
Copy link

Bug Description

When I chat open ai assistant, with chat + send message to assistant, it works fine, but when I try to use it without chat, even if I pass same variables as chat, he keep creating new threads, and never keep to the same thread.

To Reproduce

  1. Create send message to assistant, try use it with chat, it should works fine
  2. Create a set, and input the messages and variable, as it chat return, sessionId, action: sendMessage, and chatInput
  3. He will create a new thread every time you execute it manually, instead of keep in the same thread

Expected behavior

It should continue in same thread and keep conversation

Operating System

Ubuntu

n8n Version

Latest

Node.js Version

20

Database

PostgreSQL

Execution mode

main (default)

@Joffcom
Copy link
Member

Joffcom commented May 15, 2024

Hey @yuri12344,

I am not fully following what the issue is here, Are you able to provide an example workflow? I would kind of expect any thread history to only be available when using the chat option or memory which it sounds like is working as expected.

It would be interesting to see what you are actually doing so we can work out if it should use an existing thread or not.

@yuri12344
Copy link
Author

@Joffcom I have made a video about it, I think it shows better, just 3 mins videos, check it out please
https://youtu.be/VayYhBoWWDM

@yuri12344
Copy link
Author

Just simple workflow
My_workflow.json

@gvargas9
Copy link

Agree. This is an issue. Same Chat should not create a new Thread in OpenAI.
By using the same thread we do not need to resend all conversation again. This is already stored in the thread.
https://platform.openai.com/docs/api-reference/threads/object

@Joffcom
Copy link
Member

Joffcom commented May 17, 2024

I have taken a quick look and I can see the issue, When using chat the node takes the inputs in a different way as we expect the session / thread to be stored / used but on manual messages we don't currently support passing in that input.

Technically this is a feature request not a bug as it is working as intended but I have created NODE-1357 as the internal dev ticket to have this added as it could be a fairly quick change when we next look to touch that node.

@Joffcom Joffcom added the in linear Issue or PR has been created in Linear for internal review label May 17, 2024
@gvargas9
Copy link

gvargas9 commented May 17, 2024

But this also happens when using the chat model.
There is a new thread created on each reply (2 messages).
The logic should be:
New chat --> create thread
New message (On the Same chat/session ) --> update Thread

This model removes the memory element because history is stored in the thread openai

@Joffcom
Copy link
Member

Joffcom commented May 17, 2024

Hey @gvargas9,

Is that when using the chat model with the AI Assistant? Looking at the video when using the chat input with the assistant it appeared to remember the name.

@Joffcom
Copy link
Member

Joffcom commented May 17, 2024

I have just reaslised that this is actually a duplicate of an existing feature request which can be found here: https://community.n8n.io/t/memory-functionality-missing-from-openai-assistant-node/34747/17

As this exists on the forum and to save on duplication I am acutally going to close this issue and I will link the feature request to the internal ticket.

@Joffcom Joffcom closed this as not planned Won't fix, can't repro, duplicate, stale May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in linear Issue or PR has been created in Linear for internal review
Projects
None yet
Development

No branches or pull requests

3 participants