Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Fonts related to BackForwardTableViewCell to use FXFontStyles #20318

Open
data-sync-user opened this issue May 17, 2024 · 3 comments
Open

Update Fonts related to BackForwardTableViewCell to use FXFontStyles #20318

data-sync-user opened this issue May 17, 2024 · 3 comments
Assignees
@DanielDervishi
Labels
Contributor Fix A contributor has fixed this issue. It might still be opened as we're waiting for final QA approval Contributor OK This is a good issue for contributors interested in helping the project Fonts Relates to standardizing Fonts in the application

Comments

@data-sync-user
Copy link
Collaborator

data-sync-user commented May 17, 2024 •
edited

This task is part of a series of tasks to standardizing fonts to start using FXFontStyles.

Background Context:
Previously, we were using DefaultDynamicFontHelper and setting the text style, size and weight for each font, which sometimes did not match our design system. By using FXFontStyles, we can standardize our fonts and be more aligned with the design system.

Task:
Please update how we set fonts in the Firefox iOS Project related:

BackForwardTableViewCell

Acceptance Criteria:

Replace usage of DefaultDynamicFontHelper with FXFontStyles

If there are discrepancies in terms of replacing the old fonts with the new standard, we will need to bring design in to approve the PR.

Please provide before and after screenshots of the UI.

Reference:

Usage example:
FXFontStyles.Regular.headline.scaledFont()

See this PR for example of standardizing fonts for Primary Button:

https://github.com/mozilla-mobile/firefox-ios/pull/18711/files

┆Issue is synchronized with this Jira Task
@cyndichin cyndichin added Fonts Relates to standardizing Fonts in the application Contributor OK This is a good issue for contributors interested in helping the project labels May 17, 2024
@DanielDervishi DanielDervishi mentioned this issue May 17, 2024
Merged
6 tasks
@cyndichin cyndichin added the Contributor Fix A contributor has fixed this issue. It might still be opened as we're waiting for final QA approval label May 20, 2024
@data-sync-user
Copy link
Collaborator Author

➤ Adina Petridean commented:

Daniel Dervishi could you please pinpoint some before-and-after screenshots?

@data-sync-user
Copy link
Collaborator Author

➤ Daniel Dervishi commented:

Testing Instructions:
Open the application, navigate to a tab other than the home page and long press on the back button

Before:

!Screenshot 2024-06-05 at 11.07.07 AM.png|width=381,height=767,alt="Screenshot 2024-06-05 at 11.07.07 AM.png"!

After:

!Screenshot 2024-06-05 at 11.08.17 AM.png|width=355,height=768,alt="Screenshot 2024-06-05 at 11.08.17 AM.png"!

@data-sync-user
Copy link
Collaborator Author

➤ Adina Petridean commented:

Verified as fixed on v9000(42550), with iPhone 14 Pro Max (16.2).

!Screenshot 2024-06-07 at 11.26.53.png|width=1019,height=998,alt="Screenshot 2024-06-07 at 11.26.53.png"!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanielDervishi DanielDervishi

Labels
Contributor Fix A contributor has fixed this issue. It might still be opened as we're waiting for final QA approval Contributor OK This is a good issue for contributors interested in helping the project Fonts Relates to standardizing Fonts in the application
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cyndichin @data-sync-user @DanielDervishi