Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Fonts related to PhotonActionSheet to use FXFontStyles #20316

Open
data-sync-user opened this issue May 17, 2024 · 1 comment
Open

Update Fonts related to PhotonActionSheet to use FXFontStyles #20316

data-sync-user opened this issue May 17, 2024 · 1 comment
Labels
Contributor Fix A contributor has fixed this issue. It might still be opened as we're waiting for final QA approval Contributor OK This is a good issue for contributors interested in helping the project Fonts Relates to standardizing Fonts in the application

Comments

@data-sync-user
Copy link
Collaborator

data-sync-user commented May 17, 2024 •
edited

This task is part of a series of tasks to standardizing fonts to start using FXFontStyles.

Background Context:
Previously, we were using DefaultDynamicFontHelper and setting the text style, size and weight for each font, which sometimes did not match our design system. By using FXFontStyles, we can standardize our fonts and be more aligned with the design system.

Task:
Please update how we set fonts in the Firefox iOS Project related:

PhotonActionSheet

Acceptance Criteria:

Replace usage of DefaultDynamicFontHelper with FXFontStyles

If there are discrepancies in terms of replacing the old fonts with the new standard, we will need to bring design in to approve the PR.

Please provide before and after screenshots of the UI.

Reference:

Usage example:
FXFontStyles.Regular.headline.scaledFont()

See this PR for example of standardizing fonts for Primary Button:

https://github.com/mozilla-mobile/firefox-ios/pull/18711/files

┆Issue is synchronized with this Jira Task
@data-sync-user data-sync-user changed the title Update Fonts related to PhotoActionSheet to use FXFontStyles Update Fonts related to PhotonActionSheet to use FXFontStyles May 17, 2024
@cyndichin cyndichin added Fonts Relates to standardizing Fonts in the application Contributor OK This is a good issue for contributors interested in helping the project labels May 17, 2024
@tisumi99
Copy link
Contributor

PhotoActionSheet is already using FXFontStyles, but PhotonActionSheetView is still using DefaultDynamicFontHelper. I will submit a PR for PhotonActionSheetView.

@tisumi99 tisumi99 mentioned this issue May 19, 2024
Merged
6 tasks
@cyndichin cyndichin added the Contributor Fix A contributor has fixed this issue. It might still be opened as we're waiting for final QA approval label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Contributor Fix A contributor has fixed this issue. It might still be opened as we're waiting for final QA approval Contributor OK This is a good issue for contributors interested in helping the project Fonts Relates to standardizing Fonts in the application
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cyndichin @data-sync-user @tisumi99