-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stdlib] Implement missing functions in the bit
module
#2682
Comments
bit
modulebit
module
Can I take a look into this? May use this issue to track all the PRs. |
It's yours now, thank you for working on this! 🎉 Feel free to ping me once you have PRs. |
@laszlokindrat some of the originally implemented bit functions such as |
Yes, they are necessary, but indeed missing.
That would be highly appreciated, thank you! |
[External] [stdlib] implement `bit_ceil` and `bit_floor` fix modularml#2682 Co-authored-by: Jiexiang Liu <80805665+LJ-9801@users.noreply.github.com> Closes modularml#2736 MODULAR_ORIG_COMMIT_REV_ID: 3599b7ce4aba5d369ffb7e0fc09d1571dfb53f1e
[External] [stdlib] implement `bit_ceil` and `bit_floor` fix modularml#2682 Co-authored-by: Jiexiang Liu <80805665+LJ-9801@users.noreply.github.com> Closes modularml#2736 MODULAR_ORIG_COMMIT_REV_ID: 3599b7ce4aba5d369ffb7e0fc09d1571dfb53f1e Signed-off-by: Avinag <udayagiriavinag@gmail.com>
For example:
bit_ceil
,bit_floor
,has_single_bit
, and others. The immediate goal is to achieve (or get pretty close to) parity with Cpp's<bit>
. We shouldn't blindly follow the naming, and we can deviate from or extend some of these APIs slightly if we have a good reason to. Many of these functions might be simple wrappers around intrinsics.See comment: 3f9fa05#diff-20568bce7de07632ece5bf3e933c7e2eec19706a949dcae48ddd4299309ddd10R249
The text was updated successfully, but these errors were encountered: