-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
h2 header within a div with "notice" class displays box with a weird top margin #3073
Comments
I think you're hitting all the scenarios the notice class wasn't designed to handle. The better path forward I think is to abstract notices into their own |
H4 was taken special care but not H2: minimal-mistakes/_sass/minimal-mistakes/_notices.scss Lines 24 to 25 in 42f7512
|
OK. I stand corrected. And a future enhancement to build out a new notice helper. Similar to this... https://idratherbewriting.com/documentation-theme-jekyll/mydoc_alerts.html Could have swore I built this before, but maybe I'm thinking of another one of my themes.... or personal site... or both. |
This issue has been automatically marked as stale because it has not had recent activity. If this is a bug and you can still reproduce this error on the If this is a feature request, please add as an Idea under discussions and elaborate on why it is core to this project and why you feel more than 80% of users would find it beneficial. This issue will automatically be closed in 7 days if no further activity occurs. Thank you for all your contributions. |
Environment
*Info taken from https://pages.github.com/versions/ since it's a GitHub pages hosted page.
Expected behavior
The h2 header should not have such a large padding with the notice box above it.
Steps to reproduce the behavior
Use a H2 Header within a div that has the
notice<--type>
class applied.Example:
Other
I've only tested this with the H2 and H4 header. I can't say if other headers are affected too, but I wouldn't doubt this to be the case.
The H4 Header seems to be fine.
The text was updated successfully, but these errors were encountered: