Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing SigLIP to mlx-examples #747

Open
suvadityamuk opened this issue May 3, 2024 · 2 comments
Open

Contributing SigLIP to mlx-examples #747

suvadityamuk opened this issue May 3, 2024 · 2 comments

Comments

@suvadityamuk
Copy link

Hello!

I'm new to the MLX ecosystem, and I came across the fact that there is a valid CLIP implementation available in the repository. Keeping in mind that SigLIP has the same structure as that of CLIP (as per the HF implementation available), I was wondering if there would be any interest for converting the SigLIP weights to a MLX-compatible format?

Many community modelling efforts to create MLLMs have been consistently choosing SigLIP over the original CLIP model due to better performance.

Happy to discuss and understand if there are any nuances I may have overlooked, or should keep in mind. Thank you so much!
(and thank you so much for MLX, such a life-saver for folks doing ML dev on Apple Silicon!)

Thoughts? @awni

@awni
Copy link
Member

awni commented May 3, 2024

Definitely! If they run out of the box with the MLX Clip example from Hugging Face that would be awesome.

You can upload them to the HF MLX Community (https://huggingface.co/mlx-community/) or to your own HF space. Either is ok!

@x4080
Copy link

x4080 commented Jun 2, 2024

@suvadityamuk how do you convert siglip to mlx ? I tried using
python convert.py --hf-repo google/siglip-base-patch16-224
and not success, merges.txt not found or something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants