Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Changing BorderThickness will cause an exception to be displayed when nodes are selected #70

Open
MakesYT opened this issue Aug 28, 2023 · 6 comments · Fixed by #72
Labels
bug Something isn't working

Comments

@MakesYT
Copy link
Contributor

MakesYT commented Aug 28, 2023

Describe the bug
If BorderThickness is changed to a value not equal to 1, it will cause an abnormal display when the node is selected. If it is selected, the node will move slightly
Modifying BorderBrush will cause SelectedBrush to be modified together and the SelectedBrush modifications to be invalid
It is also not possible to change the Selected BorderThickness
To Reproduce
change ItemContainer style

Expected behavior
No displacement

Screenshots
image
image

Additional context
Add any other context about the problem here.

@miroiu
Copy link
Owner

miroiu commented Sep 5, 2023

Hi, I created a PR for this. Can you please check it out and let me know if that's what you expected? Thanks!

@MakesYT
Copy link
Contributor Author

MakesYT commented Sep 6, 2023

the PR is working

@MakesYT
Copy link
Contributor Author

MakesYT commented Sep 6, 2023

Another question
Modifying BorderBrush will cause SelectedBrush to be modified at the same time, which will cause the SelectedBrush modification to be invalid

@MakesYT
Copy link
Contributor Author

MakesYT commented Sep 6, 2023

like this
image
SelectedBrush modification is invalid

One idea is to modify SelectedBrush synchronously when only BorderBrush is modified, but when SelectedBrush is manually specified, the manually specified SelectedBrush will prevail

@miroiu miroiu closed this as completed in #72 Sep 6, 2023
@miroiu
Copy link
Owner

miroiu commented Sep 6, 2023

I merged the fix for border thickness and I replicated the selected brush issue, but I don't understand why it doesn't work as expected.

@miroiu miroiu reopened this Sep 6, 2023
@miroiu miroiu removed their assignment Oct 31, 2023
@miroiu
Copy link
Owner

miroiu commented Oct 31, 2023

Let me know if anyone wants to give it a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants